Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14938

make buildbot to include galera into bintars

Details

    Description

      Currently bintars that buildbot produces don't contain libgalera_smm.so.

      Publishing scripts repackage bintars to add it.

      We want to produce correct packages in buildbot and release exactly what buildbot builds.

      Either cpack should pick up libgalera_smm.so and add it to bintar or buildbot needs to repackage bintars itself.

      Attachments

        Activity

          replied, answered questions

          abychko Alexey Bychko (Inactive) added a comment - replied, answered questions

          stuck a bit with reworking the patch according to email.
          stuck point is symlink galera/<galera_library> -> ../<libgalera_smm.so>
          serg could you please help? do I need to use already implemented INSTALL_SYMLINK?

          abychko Alexey Bychko (Inactive) added a comment - stuck a bit with reworking the patch according to email. stuck point is symlink galera/<galera_library> -> ../<libgalera_smm.so> serg could you please help? do I need to use already implemented INSTALL_SYMLINK?

          found the root cause.
          cmake/cpack is ignoring files which are created in-place and not specified with INSTALL(... DESTINATION ...).
          so, the only way is to create libgalera_smm.so -> galera/<galera_library> somewhere inside source directory and then INSTALL() it.
          a bit tricky, but it works

          abychko Alexey Bychko (Inactive) added a comment - found the root cause. cmake/cpack is ignoring files which are created in-place and not specified with INSTALL(... DESTINATION ...). so, the only way is to create libgalera_smm.so -> galera/<galera_library> somewhere inside source directory and then INSTALL() it. a bit tricky, but it works

          please review 57c68068a771e338ccb456da55e8974fd38fa07d

          changes:

          • only garbd and galera library are packed
          • created symlink for galera under lib
          • changed the logic to use either galera files, galera tree, unpacked galera tarball
          • changed bintar name to include glibc_<version>
          abychko Alexey Bychko (Inactive) added a comment - please review 57c68068a771e338ccb456da55e8974fd38fa07d changes: only garbd and galera library are packed created symlink for galera under lib changed the logic to use either galera files, galera tree, unpacked galera tarball changed bintar name to include glibc_<version>

          What a prep script does (beyond many other things):
          1. rename bintar, e.g.

          mv -vi *-linux-x86_64.tar.gz ${version}-linux-glibc_214-x86_64.tar.gz
          

          2. unpack, rename dir

          tar -zxf ${version}-linux-glibc_214-${galera_arch}.tar.gz
          mv -vi *-linux-${galera_arch} ${version}-linux-glibc_214-${galera_arch}
          

          3. put galera in, repack, e.g.

          rsync -av ${dir_galera}/galera-${ver_galera_preferred_real}/bintar/galera-${ver_galera_preferred_real}-glibc_214-${galera_arch}/usr/bin/ ${version}-linux-glibc_214-${galera_arch}/bin/
          rsync -av ${dir_galera}/galera-${ver_galera_preferred_real}/bintar/galera-${ver_galera_preferred_real}-glibc_214-${galera_arch}/usr/lib/ ${version}-linux-glibc_214-${galera_arch}/lib/
          tar -czf ${version}-linux-glibc_214-${galera_arch}.tar.gz ${version}-linux-glibc_214-${galera_arch}
          

          serg Sergei Golubchik added a comment - What a prep script does (beyond many other things): 1. rename bintar, e.g. mv -vi *-linux-x86_64.tar.gz ${version}-linux-glibc_214-x86_64.tar.gz 2. unpack, rename dir tar -zxf ${version}-linux-glibc_214-${galera_arch}.tar.gz mv -vi *-linux-${galera_arch} ${version}-linux-glibc_214-${galera_arch} 3. put galera in, repack, e.g. rsync -av ${dir_galera}/galera-${ver_galera_preferred_real}/bintar/galera-${ver_galera_preferred_real}-glibc_214-${galera_arch}/usr/bin/ ${version}-linux-glibc_214-${galera_arch}/bin/ rsync -av ${dir_galera}/galera-${ver_galera_preferred_real}/bintar/galera-${ver_galera_preferred_real}-glibc_214-${galera_arch}/usr/lib/ ${version}-linux-glibc_214-${galera_arch}/lib/ tar -czf ${version}-linux-glibc_214-${galera_arch}.tar.gz ${version}-linux-glibc_214-${galera_arch}

          People

            serg Sergei Golubchik
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.