Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14856

Inconsistency in automatic adding of executable comments for new column attributes

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 10.3
    • 10.4
    • Server
    • None

    Description

      There is no obvious logic in wrapping or not wrapping new attributes into versioned comments:

      MariaDB [test]> create table t1 (pk int, c text compressed invisible);
      Query OK, 0 rows affected (0.18 sec)
       
      MariaDB [test]> show create table t1 \G
      *************************** 1. row ***************************
             Table: t1
      Create Table: CREATE TABLE `t1` (
        `pk` int(11) DEFAULT NULL,
        `c` text /*!100301 COMPRESSED*/ INVISIBLE DEFAULT NULL
      ) ENGINE=InnoDB DEFAULT CHARSET=latin1
      1 row in set (0.00 sec)
      

      Here COMPRESSED is wrapped (wrongly btw, since it was only pushed in 10.3.2), but INVISIBLE is not at all.

      I have a plausible explanation for it: COMPRESSED is optional, because it doesn't change the application logic (much); but INVISIBLE might, so maybe it's better that it fails on servers which don't support invisible columns. However, I don't know if it was really meant this way.

      Attachments

        Activity

          People

            serg Sergei Golubchik
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.