After recent pushes (see below) storage_engine-rocksdb.type_bit_indexes test started to fail like so:
--- /home/psergey/dev-git/10.2-mariarocks-r4/mysql-test/suite/storage_engine/type_bit_indexes.result 2017-10-13 16:35:16.642453564 +0300
|
+++ /home/psergey/dev-git/10.2-mariarocks-r4/mysql-test/suite/storage_engine/type_bit_indexes.reject 2017-12-07 23:37:45.628012903 +0300
|
@@ -69,7 +69,7 @@
|
(1,0xFFFF,0xFFFFFFFF,0xFFFFFFFFFFFFFFFF);
|
EXPLAIN SELECT HEX(b+c) FROM t1 WHERE c > 1 OR HEX(b) < 0xFFFFFF;
|
id select_type table type possible_keys key key_len ref rows Extra
|
-# # # # # b_c # # # #
|
+# # # # # NULL # # # #
|
SELECT HEX(b+c) FROM t1 WHERE c > 1 OR HEX(b) < 0xFFFFFF;
|
HEX(b+c)
|
10
|
@@ -98,7 +98,7 @@
|
(1,0xFFFF,0xFFFFFFFF,0xFFFFFFFFFFFFFFFF);
|
EXPLAIN SELECT DISTINCT a+0 FROM t1 ORDER BY a;
|
id select_type table type possible_keys key key_len ref rows Extra
|
-# # # # # a # # # #
|
+# # # # # NULL # # # #
|
SELECT DISTINCT a+0 FROM t1 ORDER BY a;
|
a+0
|
0
|
|
The recent pushes are these three:
commit 2c1e4d4d7a174c180cfcac5e245840aec8458b77
|
Author: Sergei Petrunia <psergey@askmonty.org>
|
Date: Tue Dec 5 16:33:38 2017 +0300
|
|
MDEV-14563: Wrong query plan for query with no PK
|
|
Part #2: Don't use the new code for the clustered PK, it is handled
|
in the special way right above.
|
|
commit a6254e5e7d0ed5d951158c43d95b41d18b71e210
|
Author: Sergei Petrunia <psergey@askmonty.org>
|
Date: Mon Dec 4 15:01:57 2017 +0300
|
|
MDEV-14563: Wrong query plan for query with no PK
|
|
TABLE_SHARE::init_from_binary_frm_image() calls handler_file->index_flags()
|
before it has set TABLE_SHARE::primary_key (it is 0 while it should be
|
MAX_KEY in my example).
|
This causes MyRocks to report wrong index flags (it thinks it's a PK while
|
it is not), which causes invalid query plans later on.
|
|
Do the only thing that seems feasible: adjust field->part_of key to have
|
correct value in ha_rocksdb::open.
|
|
commit c3803914c5c5029ac6117618fcf98b6617263970
|
Author: Sergei Petrunia <psergey@askmonty.org>
|
Date: Sat Dec 2 17:26:37 2017 +0000
|
|
MDEV-14433: RocksDB may show empty or incorrect output with rocksdb_strict_collation_check=off
|
|
Part#1: Set field->part_of_key correctly for PK fields.
|
- is part of
-
MDEV-14563
Wrong query plan for query with no PK
-
-
Closed
{"report":{"fcp":1018.7999999523163,"ttfb":470,"pageVisibility":"visible","entityId":64745,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"a412490a-7c42-4ff1-ad3f-6c9ca3de76ac","navigationType":0,"readyForUser":1087.5999999046326,"redirectCount":0,"resourceLoadedEnd":853.7999999523163,"resourceLoadedStart":478.59999990463257,"resourceTiming":[{"duration":4.1000001430511475,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":478.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":478.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":482.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":3.799999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":478.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":478.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":482.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":106.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":479.09999990463257,"connectEnd":479.09999990463257,"connectStart":479.09999990463257,"domainLookupEnd":479.09999990463257,"domainLookupStart":479.09999990463257,"fetchStart":479.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":484.90000009536743,"responseEnd":585.7000000476837,"responseStart":500.09999990463257,"secureConnectionStart":479.09999990463257},{"duration":176.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":479.7000000476837,"connectEnd":479.7000000476837,"connectStart":479.7000000476837,"domainLookupEnd":479.7000000476837,"domainLookupStart":479.7000000476837,"fetchStart":479.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":486.5,"responseEnd":656.2000000476837,"responseStart":508.09999990463257,"secureConnectionStart":479.7000000476837},{"duration":31.200000047683716,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":479.7999999523163,"connectEnd":479.7999999523163,"connectStart":479.7999999523163,"domainLookupEnd":479.7999999523163,"domainLookupStart":479.7999999523163,"fetchStart":479.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":487,"responseEnd":511,"responseStart":510,"secureConnectionStart":479.7999999523163},{"duration":33.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":479.90000009536743,"connectEnd":479.90000009536743,"connectStart":479.90000009536743,"domainLookupEnd":479.90000009536743,"domainLookupStart":479.90000009536743,"fetchStart":479.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":487.40000009536743,"responseEnd":513.4000000953674,"responseStart":512,"secureConnectionStart":479.90000009536743},{"duration":32.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":480,"connectEnd":480,"connectStart":480,"domainLookupEnd":480,"domainLookupStart":480,"fetchStart":480,"redirectEnd":0,"redirectStart":0,"requestStart":488.5,"responseEnd":512.9000000953674,"responseStart":511.2000000476837,"secureConnectionStart":480},{"duration":7.800000190734863,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":480.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":480.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":487.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":38,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":480.2000000476837,"connectEnd":480.2000000476837,"connectStart":480.2000000476837,"domainLookupEnd":480.2000000476837,"domainLookupStart":480.2000000476837,"fetchStart":480.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":491.5,"responseEnd":518.2000000476837,"responseStart":516.2999999523163,"secureConnectionStart":480.2000000476837},{"duration":8.799999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":480.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":480.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":489.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":38,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":480.5,"connectEnd":480.5,"connectStart":480.5,"domainLookupEnd":480.5,"domainLookupStart":480.5,"fetchStart":480.5,"redirectEnd":0,"redirectStart":0,"requestStart":492.2000000476837,"responseEnd":518.5,"responseStart":517.4000000953674,"secureConnectionStart":480.5},{"duration":367.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":486,"connectEnd":486,"connectStart":486,"domainLookupEnd":486,"domainLookupStart":486,"fetchStart":486,"redirectEnd":0,"redirectStart":0,"requestStart":496.59999990463257,"responseEnd":853.5999999046326,"responseStart":851.7999999523163,"secureConnectionStart":486},{"duration":367.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":486.09999990463257,"connectEnd":486.09999990463257,"connectStart":486.09999990463257,"domainLookupEnd":486.09999990463257,"domainLookupStart":486.09999990463257,"fetchStart":486.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":496.90000009536743,"responseEnd":853.7999999523163,"responseStart":852.4000000953674,"secureConnectionStart":486.09999990463257},{"duration":176.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":791.2000000476837,"connectEnd":791.2000000476837,"connectStart":791.2000000476837,"domainLookupEnd":791.2000000476837,"domainLookupStart":791.2000000476837,"fetchStart":791.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":935.5999999046326,"responseEnd":967.7999999523163,"responseStart":967.2999999523163,"secureConnectionStart":791.2000000476837},{"duration":143.29999995231628,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":996.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":996.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1140.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":154.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1018.7000000476837,"connectEnd":1018.7000000476837,"connectStart":1018.7000000476837,"domainLookupEnd":1018.7000000476837,"domainLookupStart":1018.7000000476837,"fetchStart":1018.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1140.9000000953674,"responseEnd":1173.2999999523163,"responseStart":1171.7000000476837,"secureConnectionStart":1018.7000000476837}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":39,"responseStart":470,"responseEnd":485,"domLoading":473,"domInteractive":1144,"domContentLoadedEventStart":1144,"domContentLoadedEventEnd":1183,"domComplete":1743,"loadEventStart":1743,"loadEventEnd":1744,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1124.9000000953674},{"name":"bigPipe.sidebar-id.end","time":1125.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":1125.7999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1128.0999999046326},{"name":"activityTabFullyLoaded","time":1198.2999999523163}],"measures":[],"correlationId":"253e01e59f7c07","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":352,"dbReadsTimeInMs":289,"dbConnsTimeInMs":297,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}