Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14607

storage_engine-rocksdb.type_bit_indexes fails after latest pushes

    XMLWordPrintable

    Details

      Description

      After recent pushes (see below) storage_engine-rocksdb.type_bit_indexes test started to fail like so:

      --- /home/psergey/dev-git/10.2-mariarocks-r4/mysql-test/suite/storage_engine/type_bit_indexes.result    2017-10-13 16:35:16.642453564 +0300
      +++ /home/psergey/dev-git/10.2-mariarocks-r4/mysql-test/suite/storage_engine/type_bit_indexes.reject    2017-12-07 23:37:45.628012903 +0300
      @@ -69,7 +69,7 @@
       (1,0xFFFF,0xFFFFFFFF,0xFFFFFFFFFFFFFFFF);
       EXPLAIN SELECT HEX(b+c) FROM t1 WHERE c > 1 OR HEX(b) < 0xFFFFFF;
       id     select_type     table   type    possible_keys   key     key_len ref     rows    Extra
      -#      #       #       #       #       b_c     #       #       #       #
      +#      #       #       #       #       NULL    #       #       #       #
       SELECT HEX(b+c) FROM t1 WHERE c > 1 OR HEX(b) < 0xFFFFFF;
       HEX(b+c)
       10
      @@ -98,7 +98,7 @@
       (1,0xFFFF,0xFFFFFFFF,0xFFFFFFFFFFFFFFFF);
       EXPLAIN SELECT DISTINCT a+0 FROM t1 ORDER BY a;
       id     select_type     table   type    possible_keys   key     key_len ref     rows    Extra
      -#      #       #       #       #       a       #       #       #       #
      +#      #       #       #       #       NULL    #       #       #       #
       SELECT DISTINCT a+0 FROM t1 ORDER BY a;
       a+0
       0
      
      

      The recent pushes are these three:

      commit 2c1e4d4d7a174c180cfcac5e245840aec8458b77
      Author: Sergei Petrunia <psergey@askmonty.org>
      Date:   Tue Dec 5 16:33:38 2017 +0300
       
          MDEV-14563: Wrong query plan for query with no PK
          
          Part #2: Don't use the new code for the clustered PK, it is handled
          in the special way right above.
       
      commit a6254e5e7d0ed5d951158c43d95b41d18b71e210
      Author: Sergei Petrunia <psergey@askmonty.org>
      Date:   Mon Dec 4 15:01:57 2017 +0300
       
          MDEV-14563: Wrong query plan for query with no PK
          
          TABLE_SHARE::init_from_binary_frm_image() calls handler_file->index_flags()
          before it has set TABLE_SHARE::primary_key (it is 0 while it should be
          MAX_KEY in my example).
          This causes MyRocks to report wrong index flags (it thinks it's a PK while
          it is not), which causes invalid query plans later on.
          
          Do the only thing that seems feasible: adjust field->part_of key to have
          correct value in ha_rocksdb::open.
       
      commit c3803914c5c5029ac6117618fcf98b6617263970
      Author: Sergei Petrunia <psergey@askmonty.org>
      Date:   Sat Dec 2 17:26:37 2017 +0000
       
          MDEV-14433: RocksDB may show empty or incorrect output with rocksdb_strict_collation_check=off
          
          Part#1: Set field->part_of_key correctly for PK fields.
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              elenst Elena Stepanova
              Reporter:
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: