Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14330

Move tokudb*/mysqltest manpages to correct RPM

Details

    Description

      I believe, those 2 manpages should be in tokudb subpackage, since without it they don't make sense:

      • tokuftdump.1.gz
      • tokuft_logdump.1.gz

      This one's binary is in the test subpackage, but the manpage is in the server

      • mysqltest.1.gz

      Attachments

        Activity

          mschorm Michal Schorm added a comment -

          Also when built without tokudb (for example on non x86-64 arches), its manpages are still shipped, which is not correct.

          This is from the Fedora SPECfile, where I remove them by hand:

          %if %{without tokudb}
          # because upstream ships manpages for tokudb even on architectures that tokudb doesn't support
          rm %{buildroot}%{_mandir}/man1/tokuftdump.1*
          rm %{buildroot}%{_mandir}/man1/tokuft_logdump.1*
          

          mschorm Michal Schorm added a comment - Also when built without tokudb (for example on non x86-64 arches), its manpages are still shipped, which is not correct. This is from the Fedora SPECfile, where I remove them by hand: % if %{without tokudb} # because upstream ships manpages for tokudb even on architectures that tokudb doesn't support rm %{buildroot}%{_mandir} /man1/tokuftdump .1* rm %{buildroot}%{_mandir} /man1/tokuft_logdump .1*
          mschorm Michal Schorm added a comment -

          btw I think theese files are also not used in any way.
          If that's true, it would be good to remove them from the tarballs.

          storage/tokudb/mysql-test/tokudb/t/*.py
          

          mschorm Michal Schorm added a comment - btw I think theese files are also not used in any way. If that's true, it would be good to remove them from the tarballs. storage /tokudb/mysql-test/tokudb/t/ *.py

          mysqltest.1 man page move was fixed in 10.1
          tokudb man pages were moved to storage/tokudb/man and are now part of tokudb-engine package, starting from 10.2

          The .py files we will keep as it's part of the upstream repository. It is possible that TokuDB will be removed in later versions, hence they will stay there for now. A subsequent patch might remove them as install files, but the effort does not seem justified at this point.

          cvicentiu Vicențiu Ciorbaru added a comment - mysqltest.1 man page move was fixed in 10.1 tokudb man pages were moved to storage/tokudb/man and are now part of tokudb-engine package, starting from 10.2 The .py files we will keep as it's part of the upstream repository. It is possible that TokuDB will be removed in later versions, hence they will stay there for now. A subsequent patch might remove them as install files, but the effort does not seem justified at this point.

          People

            cvicentiu Vicențiu Ciorbaru
            mschorm Michal Schorm
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.