Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14309

MTR tests require perl-Env which is not always in the default installation

Details

    Description

      Some MTR tests use include/truncate_file.inc which, in turn, uses Env perl package. Apparently, it's not installed by default on some systems, e.g. on CentOS 7, so when we run MTR tests on our RPM packages, some of them fail due to the missing package.

      It's probably not very important, if nobody complained so far. For now, I've added installation of the package to the buildbot test step, but maybe it should be pulled as a dependency for MariaDB-test.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          serg Sergei Golubchik added a comment -

          I'd rather remove the dependency. Like

          -use Env;
          		 
          -Env::import('TRUNCATE_FILE');
          		 
          -open FILE, '>', $TRUNCATE_FILE || die "Can not open file $file";
          		 
          +open FILE, '>', $ENV{TRUNCATE_FILE} || die "Can not open file $file";

          serg Sergei Golubchik added a comment - I'd rather remove the dependency. Like -use Env; -Env::import('TRUNCATE_FILE'); -open FILE, '>', $TRUNCATE_FILE || die "Can not open file $file"; +open FILE, '>', $ENV{TRUNCATE_FILE} || die "Can not open file $file";
          elenst Elena Stepanova added a comment -

          Right, it would be much better.

          elenst Elena Stepanova added a comment - Right, it would be much better.
          danblack Daniel Black added a comment -

          fwiw i did notice, it was just easy enough to work around by installing the package. +1 for the dependency removal.

          danblack Daniel Black added a comment - fwiw i did notice, it was just easy enough to work around by installing the package. +1 for the dependency removal.

          People

            serg Sergei Golubchik
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.