[MDEV-14309] MTR tests require perl-Env which is not always in the default installation Created: 2017-11-07  Updated: 2017-12-28  Resolved: 2017-12-28

Status: Closed
Project: MariaDB Server
Component/s: Packaging
Affects Version/s: 10.3
Fix Version/s: 5.5.59, 10.0.34, 10.1.31, 10.2.13

Type: Bug Priority: Minor
Reporter: Elena Stepanova Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None


 Description   

Some MTR tests use include/truncate_file.inc which, in turn, uses Env perl package. Apparently, it's not installed by default on some systems, e.g. on CentOS 7, so when we run MTR tests on our RPM packages, some of them fail due to the missing package.

It's probably not very important, if nobody complained so far. For now, I've added installation of the package to the buildbot test step, but maybe it should be pulled as a dependency for MariaDB-test.

 Comments   
Comment by Sergei Golubchik [ 2017-11-07 ]

I'd rather remove the dependency. Like

-use Env;
 
-Env::import('TRUNCATE_FILE');
 
-open FILE, '>', $TRUNCATE_FILE || die "Can not open file $file";
 
+open FILE, '>', $ENV{TRUNCATE_FILE} || die "Can not open file $file";

Comment by Elena Stepanova [ 2017-11-07 ]

Right, it would be much better.

Comment by Daniel Black [ 2017-12-28 ]

fwiw i did notice, it was just easy enough to work around by installing the package. +1 for the dependency removal.

Generated at Thu Feb 08 08:12:33 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.