Ever since MDEV-10813 cleaned up InnoDB use of atomic memory operations, some conditions around buf_block_fix() have been unnecessary.
Because buf_block_fix() is an atomic operation, there is no need to protect it with an additional mutex, like buf_page_get_gen() did when fsp_is_system_temporary() held.
UNIV_INLINE
|
ulint
|
buf_block_fix(
|
buf_page_t* bpage)
|
{
|
return(my_atomic_add32((int32*) &bpage->buf_fix_count, 1) + 1);
|
}
|
We shall remove the unnecessary bloat in buf_page_get_gen(). It might slightly improve performance in any operations that access the InnoDB buffer pool, and improve performance a little more on InnoDB temporary tables.
- relates to
-
MDEV-10813
Clean-up InnoDB atomics, memory barriers and mutexes
-
-
Closed
There are no comments yet on this issue.
{"report":{"fcp":864.6000001430511,"ttfb":162.70000004768372,"pageVisibility":"visible","entityId":64154,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"a157122a-7fa3-4fa6-95fc-3aff8c8c3de9","navigationType":0,"readyForUser":925.3000001907349,"redirectCount":0,"resourceLoadedEnd":913.9000000953674,"resourceLoadedStart":167.80000019073486,"resourceTiming":[{"duration":171.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":167.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":167.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":339.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":174.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":168,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":168,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":342.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":234.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":168.20000004768372,"connectEnd":168.20000004768372,"connectStart":168.20000004768372,"domainLookupEnd":168.20000004768372,"domainLookupStart":168.20000004768372,"fetchStart":168.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":168.20000004768372,"responseEnd":402.80000019073486,"responseStart":402.80000019073486,"secureConnectionStart":168.20000004768372},{"duration":311.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":168.40000009536743,"connectEnd":168.40000009536743,"connectStart":168.40000009536743,"domainLookupEnd":168.40000009536743,"domainLookupStart":168.40000009536743,"fetchStart":168.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":168.40000009536743,"responseEnd":480,"responseStart":480,"secureConnectionStart":168.40000009536743},{"duration":315.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":168.5,"connectEnd":168.5,"connectStart":168.5,"domainLookupEnd":168.5,"domainLookupStart":168.5,"fetchStart":168.5,"redirectEnd":0,"redirectStart":0,"requestStart":168.5,"responseEnd":483.60000014305115,"responseStart":483.60000014305115,"secureConnectionStart":168.5},{"duration":315.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":168.60000014305115,"connectEnd":168.60000014305115,"connectStart":168.60000014305115,"domainLookupEnd":168.60000014305115,"domainLookupStart":168.60000014305115,"fetchStart":168.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":168.60000014305115,"responseEnd":484.10000014305115,"responseStart":484.10000014305115,"secureConnectionStart":168.60000014305115},{"duration":316.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":168.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":168.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":484.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":315.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":168.70000004768372,"connectEnd":168.70000004768372,"connectStart":168.70000004768372,"domainLookupEnd":168.70000004768372,"domainLookupStart":168.70000004768372,"fetchStart":168.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":168.70000004768372,"responseEnd":484.40000009536743,"responseStart":484.40000009536743,"secureConnectionStart":168.70000004768372},{"duration":316,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":168.80000019073486,"connectEnd":168.80000019073486,"connectStart":168.80000019073486,"domainLookupEnd":168.80000019073486,"domainLookupStart":168.80000019073486,"fetchStart":168.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":168.80000019073486,"responseEnd":484.80000019073486,"responseStart":484.80000019073486,"secureConnectionStart":168.80000019073486},{"duration":316.2999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":168.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":168.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":485.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":316.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":169.10000014305115,"connectEnd":169.10000014305115,"connectStart":169.10000014305115,"domainLookupEnd":169.10000014305115,"domainLookupStart":169.10000014305115,"fetchStart":169.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":169.10000014305115,"responseEnd":485.40000009536743,"responseStart":485.40000009536743,"secureConnectionStart":169.10000014305115},{"duration":575,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":169.80000019073486,"connectEnd":169.80000019073486,"connectStart":169.80000019073486,"domainLookupEnd":169.80000019073486,"domainLookupStart":169.80000019073486,"fetchStart":169.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":169.80000019073486,"responseEnd":744.8000001907349,"responseStart":744.8000001907349,"secureConnectionStart":169.80000019073486},{"duration":589.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":169.90000009536743,"connectEnd":169.90000009536743,"connectStart":169.90000009536743,"domainLookupEnd":169.90000009536743,"domainLookupStart":169.90000009536743,"fetchStart":169.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":169.90000009536743,"responseEnd":759.4000000953674,"responseStart":759.4000000953674,"secureConnectionStart":169.90000009536743},{"duration":136.20000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":616.1000001430511,"connectEnd":616.1000001430511,"connectStart":616.1000001430511,"domainLookupEnd":616.1000001430511,"domainLookupStart":616.1000001430511,"fetchStart":616.1000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":616.1000001430511,"responseEnd":752.3000001907349,"responseStart":752.3000001907349,"secureConnectionStart":616.1000001430511},{"duration":80.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":813.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":813.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":893.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":80,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2bu7/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":813.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":813.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":893.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":79.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":814.7000000476837,"connectEnd":814.7000000476837,"connectStart":814.7000000476837,"domainLookupEnd":814.7000000476837,"domainLookupStart":814.7000000476837,"fetchStart":814.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":814.7000000476837,"responseEnd":894.4000000953674,"responseStart":894.4000000953674,"secureConnectionStart":814.7000000476837},{"duration":97.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":815.1000001430511,"connectEnd":815.1000001430511,"connectStart":815.1000001430511,"domainLookupEnd":815.1000001430511,"domainLookupStart":815.1000001430511,"fetchStart":815.1000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":815.1000001430511,"responseEnd":912.6000001430511,"responseStart":912.6000001430511,"secureConnectionStart":815.1000001430511},{"duration":98.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/86ee9bbc76cd1bcd8556fcdcf46241c9-CDN/lu2bu7/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":815.4000000953674,"connectEnd":815.4000000953674,"connectStart":815.4000000953674,"domainLookupEnd":815.4000000953674,"domainLookupStart":815.4000000953674,"fetchStart":815.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":815.4000000953674,"responseEnd":913.9000000953674,"responseStart":913.9000000953674,"secureConnectionStart":815.4000000953674},{"duration":105.20000004768372,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":845.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":845.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":950.9000000953674,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":42,"responseStart":162,"responseEnd":165,"domLoading":166,"domInteractive":989,"domContentLoadedEventStart":989,"domContentLoadedEventEnd":1032,"domComplete":1237,"loadEventStart":1237,"loadEventEnd":1237,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":958.7000000476837},{"name":"bigPipe.sidebar-id.end","time":959.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":959.6000001430511},{"name":"bigPipe.activity-panel-pipe-id.end","time":960.1000001430511},{"name":"activityTabFullyLoaded","time":1039.6000001430511}],"measures":[],"correlationId":"f198fad4beebab","effectiveType":"4g","downlink":9.5,"rtt":0,"serverDuration":70,"dbReadsTimeInMs":9,"dbConnsTimeInMs":15,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}