[MDEV-14111] Inplace update assert after instant adding column - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.3.2
Fix Version/s: 10.3.3
Component/s: Data Manipulation - Update
Labels:

Sprint:
10.3.3-1

Description

In MariaDB 10.3.2, instant adding columns for innodb is supported.
After instant adding columns, the inplace update trigger assertion in some cases.

How to repeat:
create table t1 (c1 int primary key, c2 int);
insert into t1 values(1,1);
alter table t1 add column d1 varchar(20) not null default 'aaa';
update t1 set d1 = '' where c1 = 1; – assert in rec_set_nth_field()

The length of "d1" stored in the record is 0, because of instant adding columns. After update, the length is 0 also. But it can't do inplace update here.

So, it need to do some special check for rec_offs_nth_default() in row_upd_changes_field_size_or_external();

The patch can be work for it.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

inplace_update_fix.patch
2 kB
2017-10-24 02:27

Issue Links

is caused by

MDEV-11369 Instant add column for InnoDB

Closed

Activity

Ascending order - Click to sort in descending order

vinchen created issue - 2017-10-24 02:26

vinchen made changes - 2017-10-24 02:27

Field	Original Value	New Value
Attachment		inplace_update_fix.patch [ 44366 ]

vinchen made changes - 2017-10-24 03:01

Description

In MariaDB 10.3.2, instant adding columns for innodb is supported.
After instant adding columns, the inplace update trigger assertion in some cases.

How to repeat:
create table t1 (c1 int primary key, c2 int);
insert into t1 values(1,1);
alter table t1 add column d1 varchar(20) not null default 'aaa';
update t1 set d1 = '' where c1 = 1; {color:red}-- assert in rec_set_nth_field(){color}

The length of "d1" stored in the record is 0, because of instant adding columns. After update, the length is 0 also. But it can do inplace update here.

So, it need to do some special check for rec_offs_nth_default() in row_upd_changes_field_size_or_external();

The patch can be work for it.

In MariaDB 10.3.2, instant adding columns for innodb is supported.
After instant adding columns, the inplace update trigger assertion in some cases.

How to repeat:
create table t1 (c1 int primary key, c2 int);
insert into t1 values(1,1);
alter table t1 add column d1 varchar(20) not null default 'aaa';
update t1 set d1 = '' where c1 = 1; {color:red}-- assert in rec_set_nth_field(){color}

The length of "d1" stored in the record is 0, because of instant adding columns. After update, the length is 0 also. But it can't do inplace update here.

So, it need to do some special check for rec_offs_nth_default() in row_upd_changes_field_size_or_external();

The patch can be work for it.