Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.2.9
-
None
-
Fedora - all
Description
We use aditional compiler options on Fedora, by default.
It looks like this:
[ 18%] Building CXX object storage/tokudb/PerconaFT/util/CMakeFiles/util_static.dir/dbt.cc.o |
cd /builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/util && /usr/bin/c++ -DHAVE_CONFIG_H -DHAVE_SYSTEMD -DMYSQL_TOKUDB_ENGINE=1 -DTOKUDB_VERSION=5.6.37-82.2 -DTOKU_DEBUG_TXN_SYNC=1 -DTOKU_PTHREAD_DEBUG=1 -D_DEFAULT_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=600 -D__LONG_LONG_SUPPORTED -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/buildheader -I/builddir/build/BUILD/mariadb-10.2.9/include -I/builddir/build/BUILD/mariadb-10.2.9/sql -I/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/./xz/include -I/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/./snappy/include -I/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/portability -I/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT -isystem /usr/local/include -std=c++11 -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fPIC -pie -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DWITH_INNODB_DISALLOW_WRITES -fPIC -fno-rtti -std=c++11 -Wno-missing-field-initializers -Wno-missing-field-initializers -Wstrict-null-sentinel -Winit-self -Wswitch -Wtrampolines -Wlogical-op -Wmissing-format-attribute -Wno-error=missing-format-attribute -Wno-error=maybe-uninitialized -fno-rtti -fno-exceptions -Wno-error=nonnull-compare -Wpacked -fno-omit-frame-pointer -Wno-error=strict-overflow -Wextra -Wno-missing-noreturn -Wmissing-declarations -Wpointer-arith -Wmissing-format-attribute -Wshadow -Wcast-align -Wall -Werror -g3 -O0 -O -g -static-libgcc -fno-omit-frame-pointer -fno-strict-aliasing -Wno-uninitialized -DENABLED_DEBUG_SYNC -ggdb3 -DSAFE_MUTEX -DSAFEMALLOC -Wall -Wextra -Wformat-security -Wno-init-self -Wvla -Woverloaded-virtual -Wno-unused-parameter -Wno-vla -DTOKUDB_DEBUG -fPIC -o CMakeFiles/util_static.dir/dbt.cc.o -c /builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/util/dbt.cc |
And it fails with following error:
|
|
make[2]: Leaving directory '/builddir/build/BUILD/mariadb-10.2.9' |
/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/util/dbt.cc: In function 'int toku_dbt_set(uint32_t, const void*, DBT*, simple_dbt*)': |
/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/util/dbt.cc:201:21: error: this statement may fall through [-Werror=implicit-fallthrough=] |
d->ulen = 0;
|
~~~~~~~~^~~
|
/builddir/build/BUILD/mariadb-10.2.9/storage/tokudb/PerconaFT/util/dbt.cc:203:9: note: here |
case (DB_DBT_REALLOC): |
^~~~
|
cc1plus: all warnings being treated as errors
|
Here's some info about switch-case fallthrough, just in case you didn't know:
https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Priority | Minor [ 4 ] | Major [ 3 ] |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Fix Version/s | 10.2 [ 14601 ] |
| Assignee | Sergei Golubchik [ serg ] |
Can be closed,
I checked that again for 10.2.12 & 10.1.30 releases and the issue didn't returned.
| Component/s | Compiling [ 11001 ] | |
| Component/s | Server [ 13907 ] | |
| Fix Version/s | 10.2.10 [ 22615 ] | |
| Fix Version/s | 10.1.30 [ 22637 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 82896 ] | MariaDB v4 [ 152932 ] |
On 10.2 solved by 10.2.10 release