Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13960

mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/pat.c:773:8: warning: this statement may fall through [-Wimplicit-fallthrough=]

Details

    Description

      Source code is

        case GRN_OBJ_KEY_UINT :\
      		 
          if (((pat)->obj.header.domain != GRN_DB_TOKYO_GEO_POINT) &&\
      		 
              ((pat)->obj.header.domain != GRN_DB_WGS84_GEO_POINT)) {\
      		 
            grn_hton((keybuf), (key), (size));\
      		 
            break;\
      		 
          }\

      Suggest move break from inside if to outside.

      Attachments

        Activity

          kou Kouhei Sutou added a comment -

          This code is for backward compatibility and this break position is right.

          We need to add a /* FALLTHROUGH */ comment.

          I'll do it in upstream and update bundled Groonga as MDEV-20544.

          kou Kouhei Sutou added a comment - This code is for backward compatibility and this break position is right. We need to add a /* FALLTHROUGH */ comment. I'll do it in upstream and update bundled Groonga as MDEV-20544 .

          People

            kou Kouhei Sutou
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.