Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13846

Dead code ha_innobase::records_in_range() for SPATIAL INDEX

Details

    Description

      The function rtr_estimate_n_rows_in_range() looks like dead and buggy code.
      If it were called, it should trigger rec_offs_validate() assertion failure in debug builds,
      because it is not updating 'offsets' in sync with 'rec'.

      Spatial indexes define a partial order, not a total order. A range cannot really exist without total order. Therefore, the virtual member function handler::records_in_range() probably should not executed on a SPATIAL INDEX at all.

      We should probably remove the code from MariaDB Server 10.2.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          marko Marko Mäkelä created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Workflow MariaDB v3 [ 82667 ] MariaDB v4 [ 140420 ]

          People

            marko Marko Mäkelä
            marko Marko Mäkelä
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.