Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13620

Improve documentation and help text for MariaDB Backup's --plugin-dir option

Details

    • 10.1.30

    Description

      In MDEV-13400, I mentioned that MariaDB backup ignores the --plugin-dir command-line option during the backup stage. Instead, the tool queries the server for its value, and it always uses that value. It sounds like we do not want to change this.

      I believe that the --plugin-dir command-line option is read during the prepare stage.

      We should probably update the --help text of the mariabackup tool to specify that the --plugin-dir option is only valid during the prepare stage. We should probably add a similar note to the documentation:

      https://mariadb.com/kb/en/the-mariadb-library/mariabackup-options/

      Should the utility also warn the user if they specify the --plugin-dir command-line option during the backup stage?

      Attachments

        Activity

          wlad Vladislav Vaintroub added a comment - - edited

          since MDEV-13608, plugin-dir is also used during backup stage to set the path for the client-side authentication plugins. Unfortunate consequence of mariabackup being half-server/half-client is that the same options can be (and now are) interpreted in different ways. So, no we cannot ignore or warn if it is used on command line.

          wlad Vladislav Vaintroub added a comment - - edited since MDEV-13608 , plugin-dir is also used during backup stage to set the path for the client-side authentication plugins. Unfortunate consequence of mariabackup being half-server/half-client is that the same options can be (and now are) interpreted in different ways. So, no we cannot ignore or warn if it is used on command line.

          So it sounds like we won't be fixing this right ?

          julien.fritsch Julien Fritsch added a comment - So it sounds like we won't be fixing this right ?

          I can fix it, no big deal. I wrote an explanation in previous entry to set expectation of what to expect from this option. Usually, this does not really need any setting, and if it does need, people are doing something "special"

          wlad Vladislav Vaintroub added a comment - I can fix it, no big deal. I wrote an explanation in previous entry to set expectation of what to expect from this option. Usually, this does not really need any setting, and if it does need, people are doing something "special"

          People

            wlad Vladislav Vaintroub
            GeoffMontee Geoff Montee (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.