Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13563

lock DDL for mariabackup in 10.2+

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.2.9
    • Backup
    • None

    Description

      In MySQL 5.7 (and MariaDB 10.2.2 onwards), the InnoDB redo log is not self-contained with respect to some DDL operations.
      Most notably, WL#7277 disables the redo logging of data pages in the initial phase of ALTER TABLE…ALGORITHM=INPLACE. (The online_log apply is still being redo-logged.) The presence of a MLOG_INDEX_LOAD record indicates that some data was omitted from the redo log.

      Percona implements a workaround. We should look at their implementation.

      MDEV-13564 mentions another class of operations that makes the redo log not self-contained: TRUNCATE TABLE and undo tablespace truncation.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13802 mariabackup --lock-ddl-per-table fails when table names contain backticks

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13825 mariabackup --lock-ddl-per-table does not properly lock FULLTEXT auxiliary tables

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13564 TRUNCATE TABLE and undo tablespace truncation are not compatible with Mariabackup

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-16809 Allow full redo logging for ALTER TABLE

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-14545 Backup fails due to MLOG_INDEX_LOAD record

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            wlad Vladislav Vaintroub created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            Description in 10.2, DDL commands are not written to the innodb redo log. Percona implements a workaround with https://blueprints.launchpad.net/percona-xtrabackup/+spec/mdl-lock-tables. We should look at their implementation In MySQL 5.7 (and MariaDB 10.2.2 onwards), the InnoDB redo log is not self-contained with respect to some DDL operations.
            Most notably, [WL#7277|http://dev.mysql.com/worklog/task/?id=7277] disables the redo logging of data pages in the initial phase of ALTER TABLE…ALGORITHM=INPLACE. (The online_log apply is still being redo-logged.) The presence of a [MLOG_INDEX_LOAD record|https://github.com/mysql/mysql-server/commit/c8b6a6b4e0574910822945be1b041407a822f2c1] indicates that some data was omitted from the redo log.

            Percona implements [a workaround|https://blueprints.launchpad.net/percona-xtrabackup/+spec/mdl-lock-tables]. We should look at their implementation.

            MDEV-13564 mentions another class of operations that makes the redo log not self-contained: TRUNCATE TABLE and undo tablespace truncation.
            marko Marko Mäkelä made changes -
            Fix Version/s 10.2 [ 14601 ]
            wlad Vladislav Vaintroub made changes -
            Assignee Vladislav Vaintroub [ wlad ]
            wlad Vladislav Vaintroub made changes -
            Fix Version/s 10.2.9 [ 22611 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 82146 ] MariaDB v4 [ 133330 ]

            People

              wlad Vladislav Vaintroub
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.