Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13560

restart_and_restore.inc does not pass --innodb-undo-tablespaces to --copy-back

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1(EOL)
    • 10.1.29
    • Tests
    • 10.1.29

    Description

      We should run all of --suite=mariabackup tests with at least two different combinations for innodb_undo_tablespaces. The default value is 0.

      A major problem is that the restore tests always invoke --copy-back without an innodb_undo_tablespaces parameter. I tested both by invoking

      ./mtr --mysqld=--innodb-undo-tablespaces=3 --suite=mariabackup

      and by creating an .opt file with the parameter in it.
      Backup does get the parameter right, maybe also prepare does get it.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12988 backup fails if innodb_undo_tablespaces>0

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            elenst Elena Stepanova made changes -
            Assignee Andrii Nikitin [ anikitin ] Elena Stepanova [ elenst ]
            elenst Elena Stepanova made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            elenst Elena Stepanova made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            elenst Elena Stepanova added a comment -

            It's been done in a development tree, but waiting for a decision whether it's needed after all.

            elenst Elena Stepanova added a comment - It's been done in a development tree, but waiting for a decision whether it's needed after all.
            marko Marko Mäkelä added a comment -

            If I remember correctly, wlad suggested that mariabackup --copy-back should ignore the innodb_undo_tablespaces parameter and copy all the undo* files that it finds. And I presume, to remove any other undo%03u files from the target.

            marko Marko Mäkelä added a comment - If I remember correctly, wlad suggested that mariabackup --copy-back should ignore the innodb_undo_tablespaces parameter and copy all the undo* files that it finds. And I presume, to remove any other undo%03u files from the target.
            elenst Elena Stepanova made changes -
            Assignee Elena Stepanova [ elenst ] Vladislav Vaintroub [ wlad ]
            serg Sergei Golubchik made changes -
            Sprint 10.1.29 [ 202 ]
            wlad Vladislav Vaintroub made changes -
            issue.field.resolutiondate 2017-11-03 16:03:42.0 2017-11-03 16:03:42.405
            wlad Vladislav Vaintroub made changes -
            Fix Version/s 10.1.29 [ 22636 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 82142 ] MariaDB v4 [ 152646 ]

            People

              wlad Vladislav Vaintroub
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.