Type:
Task
Priority:
Major
Resolution:
Fixed
This is a self-containing sub-task of MDEV-10591 .
It's done separately, to reduce the patch size for MDEV-10591 , to easier reviewing purposes.
Currently SQLCOM_CALL is handled in a huge piece of code in a switch in mysql_execute_command() :
case SQLCOM_CALL:
{
// around 50 code lines
}
We'll introduce a new class Sql_cmd_call and move this code to Sql_cmd_call::execute .
After this change, CALL statements will be handled in the same way with other statements using Sql_cmd based implementations:
ALTER TABLE
ALTER SEQUENCE
CHECK
OPTIMIZE
REPAIR
SIGNAL
RESIGNAL
GET DIAGNOSTICS
TRUNCATE
Reasoning:
MDEV-10591 will need more data (other than LEX::sphead ) to execute the query: a pointer to Sp_handler will be needed, to distinguish between calls for standalone vs package procedures. Adding a new member to LEX is not a good idea.
All statements should eventually be refactored to use the Sql_cmd infrastructure anyway.
There are no comments yet on this issue.
{"report":{"fcp":989,"ttfb":204,"pageVisibility":"visible","entityId":62684,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"740eef8b-651a-4559-b197-c42757c688c1","navigationType":0,"readyForUser":1062.7000007629395,"redirectCount":0,"resourceLoadedEnd":1087.7000007629395,"resourceLoadedStart":208.80000019073486,"resourceTiming":[{"duration":247,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":208.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":208.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":455.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":247.10000038146973,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":209,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":209,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":456.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":268.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":209.20000076293945,"connectEnd":209.20000076293945,"connectStart":209.20000076293945,"domainLookupEnd":209.20000076293945,"domainLookupStart":209.20000076293945,"fetchStart":209.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":209.20000076293945,"responseEnd":477.80000019073486,"responseStart":477.80000019073486,"secureConnectionStart":209.20000076293945},{"duration":331.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":209.4000005722046,"connectEnd":209.4000005722046,"connectStart":209.4000005722046,"domainLookupEnd":209.4000005722046,"domainLookupStart":209.4000005722046,"fetchStart":209.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":209.4000005722046,"responseEnd":540.8000001907349,"responseStart":540.8000001907349,"secureConnectionStart":209.4000005722046},{"duration":335.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":209.60000038146973,"connectEnd":209.60000038146973,"connectStart":209.60000038146973,"domainLookupEnd":209.60000038146973,"domainLookupStart":209.60000038146973,"fetchStart":209.60000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":209.60000038146973,"responseEnd":544.7000007629395,"responseStart":544.7000007629395,"secureConnectionStart":209.60000038146973},{"duration":335.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":209.70000076293945,"connectEnd":209.70000076293945,"connectStart":209.70000076293945,"domainLookupEnd":209.70000076293945,"domainLookupStart":209.70000076293945,"fetchStart":209.70000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":209.70000076293945,"responseEnd":545.3000001907349,"responseStart":545.3000001907349,"secureConnectionStart":209.70000076293945},{"duration":335.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":209.9000005722046,"connectEnd":209.9000005722046,"connectStart":209.9000005722046,"domainLookupEnd":209.9000005722046,"domainLookupStart":209.9000005722046,"fetchStart":209.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":209.9000005722046,"responseEnd":545.7000007629395,"responseStart":545.7000007629395,"secureConnectionStart":209.9000005722046},{"duration":411.6000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":210.10000038146973,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":210.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":621.7000007629395,"responseStart":0,"secureConnectionStart":0},{"duration":336,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":210.30000019073486,"connectEnd":210.30000019073486,"connectStart":210.30000019073486,"domainLookupEnd":210.30000019073486,"domainLookupStart":210.30000019073486,"fetchStart":210.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":210.30000019073486,"responseEnd":546.3000001907349,"responseStart":546.3000001907349,"secureConnectionStart":210.30000019073486},{"duration":411.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":210.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":210.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":621.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":336.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":210.70000076293945,"connectEnd":210.70000076293945,"connectStart":210.70000076293945,"domainLookupEnd":210.70000076293945,"domainLookupStart":210.70000076293945,"fetchStart":210.70000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":210.70000076293945,"responseEnd":547.1000003814697,"responseStart":547.1000003814697,"secureConnectionStart":210.70000076293945},{"duration":551.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":217.9000005722046,"connectEnd":217.9000005722046,"connectStart":217.9000005722046,"domainLookupEnd":217.9000005722046,"domainLookupStart":217.9000005722046,"fetchStart":217.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":217.9000005722046,"responseEnd":769.2000007629395,"responseStart":769.2000007629395,"secureConnectionStart":217.9000005722046},{"duration":857.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":217.9000005722046,"connectEnd":217.9000005722046,"connectStart":217.9000005722046,"domainLookupEnd":217.9000005722046,"domainLookupStart":217.9000005722046,"fetchStart":217.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":217.9000005722046,"responseEnd":1075.1000003814697,"responseStart":1075.1000003814697,"secureConnectionStart":217.9000005722046},{"duration":136.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":633.9000005722046,"connectEnd":633.9000005722046,"connectStart":633.9000005722046,"domainLookupEnd":633.9000005722046,"domainLookupStart":633.9000005722046,"fetchStart":633.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":633.9000005722046,"responseEnd":770.4000005722046,"responseStart":770.4000005722046,"secureConnectionStart":633.9000005722046},{"duration":180.20000076293945,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":907.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":907.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1087.7000007629395,"responseStart":0,"secureConnectionStart":0},{"duration":233.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":908.5,"connectEnd":908.5,"connectStart":908.5,"domainLookupEnd":908.5,"domainLookupStart":908.5,"fetchStart":908.5,"redirectEnd":0,"redirectStart":0,"requestStart":908.5,"responseEnd":1141.8000001907349,"responseStart":1141.8000001907349,"secureConnectionStart":908.5},{"duration":237.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":909,"connectEnd":909,"connectStart":909,"domainLookupEnd":909,"domainLookupStart":909,"fetchStart":909,"redirectEnd":0,"redirectStart":0,"requestStart":909,"responseEnd":1146.5,"responseStart":1146.5,"secureConnectionStart":909}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":44,"responseStart":204,"responseEnd":215,"domLoading":207,"domInteractive":1112,"domContentLoadedEventStart":1112,"domContentLoadedEventEnd":1148,"domComplete":1428,"loadEventStart":1428,"loadEventEnd":1429,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1101.9000005722046},{"name":"bigPipe.sidebar-id.end","time":1102.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1102.9000005722046},{"name":"bigPipe.activity-panel-pipe-id.end","time":1103.5},{"name":"activityTabFullyLoaded","time":1158.3000001907349}],"measures":[],"correlationId":"8e5c7da2f7e475","effectiveType":"4g","downlink":9.4,"rtt":0,"serverDuration":103,"dbReadsTimeInMs":14,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}