Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13529

Add class Sql_cmd_call

Details

    Description

      This is a self-containing sub-task of MDEV-10591.
      It's done separately, to reduce the patch size for MDEV-10591, to easier reviewing purposes.

      Currently SQLCOM_CALL is handled in a huge piece of code in a switch in mysql_execute_command():

      case SQLCOM_CALL:
      		 
        {
      		 
          // around 50 code lines
      		 
        }

      We'll introduce a new class Sql_cmd_call and move this code to Sql_cmd_call::execute.

      After this change, CALL statements will be handled in the same way with other statements using Sql_cmd based implementations:

      • ALTER TABLE
      • ALTER SEQUENCE
      • CHECK
      • OPTIMIZE
      • REPAIR
      • SIGNAL
      • RESIGNAL
      • GET DIAGNOSTICS
      • TRUNCATE

      Reasoning:

      • MDEV-10591 will need more data (other than LEX::sphead) to execute the query: a pointer to Sp_handler will be needed, to distinguish between calls for standalone vs package procedures. Adding a new member to LEX is not a good idea.
      • All statements should eventually be refactored to use the Sql_cmd infrastructure anyway.

      Attachments

        Issue Links

          blocks

          Technical task - A technical task. MDEV-10591 Oracle-style packages

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description
            This is a self-containing sub-task of MDEV-10591.
            It's done separately, to reduce the patch size for MDEV-10591, to easier reviewing purposes.

            Currently {{SQLCOM_CALL}} is handled in a huge piece of code in a {{switch}} in {{mysql_execute_command()}}:

            {code:sql}
            case SQLCOM_CALL:
              {
                // around 50 code lines
              }
            {code}

            We'll introduce a new class {{Sql_cmd_call}} and move this code to {{Sql_cmd_call::execute}}.

            After this change, {{CALL}} statements will be handled in the same way with other statements using {{Sql_cmd}} based implementations:
            - ALTER TABLE
            - ALTER SEQUENCE
            - CHECK
            - OPTIMIZE
            - REPAIR
            - SIGNAL
            - RESIGNAL
            - GET DIAGNOSTICS
            - TRUNCATE

            Reasoning:
            - MDEV-10591 will need more data (other than {{LEX::sphead}}) to execute the query: a pointer to {{Sp_handler}} will be needed, to distinguish between calls for standalone vs package procedures. Adding a new member to {{LEX}} is not a good idea.
            - All statements should eventually be refactored to use the {{Sql_cmd}} infrastructure anyway.
            		This is a self-containing sub-task of MDEV-10591.
            It's done separately, to reduce the patch size for MDEV-10591, to easier reviewing purposes.

            Currently {{SQLCOM_CALL}} is handled in a huge piece of code in a {{switch}} in {{mysql_execute_command()}}:

            {code:sql}
            case SQLCOM_CALL:
              {
                // around 50 code lines
              }
            {code}

            We'll introduce a new class {{Sql_cmd_call}} and move this code to {{Sql_cmd_call::execute}}.

            After this change, {{CALL}} statements will be handled in the same way with other statements using {{Sql_cmd}} based implementations:
            - ALTER TABLE
            - ALTER SEQUENCE
            - CHECK
            - OPTIMIZE
            - REPAIR
            - SIGNAL
            - RESIGNAL
            - GET DIAGNOSTICS
            - TRUNCATE

            Reasoning:
            - MDEV-10591 will need more data (other than {{LEX::sphead}}) to execute the query: a pointer to {{Sp_handler}} will be needed, to distinguish between calls for standalone vs package procedures. Adding a new member to {{LEX}} is not a good idea.
            - All statements should eventually be refactored to use the {{Sql_cmd}} infrastructure anyway.
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2017-08-15 13:29:08.0 2017-08-15 13:29:08.411
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.1 [ 22532 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 82092 ] MariaDB v4 [ 133328 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.