Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13288

Regression: test plugins.cracklib_password_check fails on all platforms in downstream Debian based distributions

Details

    • 10.1.29

    Description

      See https://launchpad.net/~mysql-ubuntu/+archive/ubuntu/mariadb-10.1/+builds?build_text=&build_state=all as of today.

      On all platforms we get this failure:

      plugins.cracklib_password_check          w3 [ fail ]
              Test ended at 2017-07-10 16:09:02
       
      CURRENT_TEST: plugins.cracklib_password_check
      mysqltest: At line 30: query 'grant select on *.* to foobar identified by 'q$%^&*rty'' failed: 1819: Your password does not satisfy the current policy requirements
       
      The result from queries just before the failure was:
      < snip >
      Error	1819	Your password does not satisfy the current policy requirements
      grant select on *.* to foocar identified by 'racoof';
      ERROR HY000: Your password does not satisfy the current policy requirements
       
       
       
      plugins.two_password_validations         w3 [ fail ]
              Test ended at 2017-07-10 16:09:04
       
      CURRENT_TEST: plugins.two_password_validations
      mysqltest: At line 21: query 'grant select on *.* to foobar identified by 'q$%^&*R1234ty'' failed: 1819: Your password does not satisfy the current policy requirements
       
      The result from queries just before the failure was:
      install soname "simple_password_check";
      grant select on *.* to Fff_fff1 identified by '1fff_ffF';
      drop user Fff_fff1;
      install soname "cracklib_password_check";
      grant select on *.* to foobar identified by 'q$%^&*R1234ty';
      

      Why is this? I don't see anything in the release notes, commits in debian/* or in other obvious places what was changed since 10.1.24 so that this started to fail.

      This is blocking security uploads to Ubuntu 17.04 at the moment (https://bugs.launchpad.net/ubuntu/+source/mariadb-10.0/+bug/1698689) so I marked it serious.

      This is also a symptom of our long standing challenges in quality - we seem to get test suite discoverable regressions in stable releases every now and then, even though they should be easy to detect and fix before making a new release.

      FYI cvicentiu and oerdnj

      Attachments

        Activity

          oerdnj Ondřej Surý (Inactive) added a comment - That would be https://anonscm.debian.org/git/pkg-mysql/mariadb-10.1.git/commit/?id=97b43b910d4b095e16dfa7834bb0a6e059075ec9

          Thanks oerdnj ! All builds now green at https://launchpad.net/~mysql-ubuntu/+archive/ubuntu/mariadb-10.1/+builds?build_text=&build_state=all

          Can you please also upstream that fix to https://github.com/MariaDB/server/blob/10.1/debian/control and other relevant branches (10.2, 10.3?).

          otto Otto Kekäläinen added a comment - Thanks oerdnj ! All builds now green at https://launchpad.net/~mysql-ubuntu/+archive/ubuntu/mariadb-10.1/+builds?build_text=&build_state=all Can you please also upstream that fix to https://github.com/MariaDB/server/blob/10.1/debian/control and other relevant branches (10.2, 10.3?).

          Closing it, as agreed with Vicentiu today.

          julien.fritsch Julien Fritsch added a comment - Closing it, as agreed with Vicentiu today.

          NOTE: cracklib-runtime was never "upstreamed"

          See
          https://github.com/MariaDB/server/blob/10.5/debian/control#L5-L35
          https://github.com/MariaDB/server/blob/10.5/debian/autobake-deb.sh#L45-L51

          This will be fixed eventually when https://salsa.debian.org/mariadb-team/mariadb-10.3/blob/master/debian/control#L9 is merged upstream (part of MDEV-6284).

          You can close this or leave it open but assigned to be or faust

          otto Otto Kekäläinen added a comment - NOTE: cracklib-runtime was never "upstreamed" See https://github.com/MariaDB/server/blob/10.5/debian/control#L5-L35 https://github.com/MariaDB/server/blob/10.5/debian/autobake-deb.sh#L45-L51 This will be fixed eventually when https://salsa.debian.org/mariadb-team/mariadb-10.3/blob/master/debian/control#L9 is merged upstream (part of MDEV-6284 ). You can close this or leave it open but assigned to be or faust

          otto cracklib-runtime as part of debian/control will be part of the next 10.1 release and it will be merged into next versions as well.

          cvicentiu Vicențiu Ciorbaru added a comment - otto cracklib-runtime as part of debian/control will be part of the next 10.1 release and it will be merged into next versions as well.

          People

            cvicentiu Vicențiu Ciorbaru
            otto Otto Kekäläinen
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.