We'll move the members "LEX_CSTRING user" and "LEX_CSTRING host" and associated methods from LEX_USER to a separate structure:
struct AUTHID
|
{
|
LEX_CSTRING user, host;
|
void init() { memset(this, 0, sizeof(*this)); }
|
void copy(MEM_ROOT *root, const LEX_CSTRING *usr, const LEX_CSTRING *host);
|
bool is_role() const { return user.str[0] && !host.str[0]; }
|
void set_lex_string(LEX_CSTRING *l, char *buf)
|
{
|
if (is_role())
|
*l= user;
|
else
|
{
|
l->str= buf;
|
l->length= strxmov(buf, user.str, "@", host.str, NullS) - buf;
|
}
|
}
|
};
|
and derive LEX_USER from it:
struct LEX_USER: public AUTHID
|
{
|
LEX_CSTRING plugin, auth;
|
LEX_CSTRING pwtext, pwhash;
|
void reset_auth()
|
{
|
pwtext.length= pwhash.length= plugin.length= auth.length= 0;
|
pwtext.str= pwhash.str= 0;
|
plugin.str= auth.str= "";
|
}
|
};
|
This will allow to declare (variables and members) and pass user and host as a single structure.
Deriving LEX_USER from the new structure AUTHID will minimize code changes.
{"report":{"fcp":1155,"ttfb":165.5,"pageVisibility":"visible","entityId":62161,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"9a99ddf9-7e44-4f65-bba9-88aa75142514","navigationType":0,"readyForUser":1258.3000001907349,"redirectCount":0,"resourceLoadedEnd":1152,"resourceLoadedStart":171,"resourceTiming":[{"duration":301.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":171,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":171,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":472.5,"responseStart":0,"secureConnectionStart":0},{"duration":301.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":171.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":171.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":472.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":311,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":171.5,"connectEnd":171.5,"connectStart":171.5,"domainLookupEnd":171.5,"domainLookupStart":171.5,"fetchStart":171.5,"redirectEnd":0,"redirectStart":0,"requestStart":171.5,"responseEnd":482.5,"responseStart":482.5,"secureConnectionStart":171.5},{"duration":352.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":171.7000002861023,"connectEnd":171.7000002861023,"connectStart":171.7000002861023,"domainLookupEnd":171.7000002861023,"domainLookupStart":171.7000002861023,"fetchStart":171.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":171.7000002861023,"responseEnd":524.3000001907349,"responseStart":524.3000001907349,"secureConnectionStart":171.7000002861023},{"duration":356,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":172,"connectEnd":172,"connectStart":172,"domainLookupEnd":172,"domainLookupStart":172,"fetchStart":172,"redirectEnd":0,"redirectStart":0,"requestStart":172,"responseEnd":528,"responseStart":528,"secureConnectionStart":172},{"duration":356.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":172,"connectEnd":172,"connectStart":172,"domainLookupEnd":172,"domainLookupStart":172,"fetchStart":172,"redirectEnd":0,"redirectStart":0,"requestStart":172,"responseEnd":528.4000000953674,"responseStart":528.4000000953674,"secureConnectionStart":172},{"duration":356.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":172.30000019073486,"connectEnd":172.30000019073486,"connectStart":172.30000019073486,"domainLookupEnd":172.30000019073486,"domainLookupStart":172.30000019073486,"fetchStart":172.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":172.30000019073486,"responseEnd":528.8000001907349,"responseStart":528.8000001907349,"secureConnectionStart":172.30000019073486},{"duration":493.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":172.7000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":172.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":666.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":356.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":172.90000009536743,"connectEnd":172.90000009536743,"connectStart":172.90000009536743,"domainLookupEnd":172.90000009536743,"domainLookupStart":172.90000009536743,"fetchStart":172.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":172.90000009536743,"responseEnd":529.3000001907349,"responseStart":529.3000001907349,"secureConnectionStart":172.90000009536743},{"duration":493.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":173,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":173,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":666.5,"responseStart":0,"secureConnectionStart":0},{"duration":356.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":173.2000002861023,"connectEnd":173.2000002861023,"connectStart":173.2000002861023,"domainLookupEnd":173.2000002861023,"domainLookupStart":173.2000002861023,"fetchStart":173.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":173.2000002861023,"responseEnd":529.9000000953674,"responseStart":529.9000000953674,"secureConnectionStart":173.2000002861023},{"duration":594.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":179.7000002861023,"connectEnd":179.7000002861023,"connectStart":179.7000002861023,"domainLookupEnd":179.7000002861023,"domainLookupStart":179.7000002861023,"fetchStart":179.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":179.7000002861023,"responseEnd":774.4000000953674,"responseStart":774.4000000953674,"secureConnectionStart":179.7000002861023},{"duration":972.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":179.80000019073486,"connectEnd":179.80000019073486,"connectStart":179.80000019073486,"domainLookupEnd":179.80000019073486,"domainLookupStart":179.80000019073486,"fetchStart":179.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":179.80000019073486,"responseEnd":1152,"responseStart":1152,"secureConnectionStart":179.80000019073486},{"duration":295.2999997138977,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":734.2000002861023,"connectEnd":734.2000002861023,"connectStart":734.2000002861023,"domainLookupEnd":734.2000002861023,"domainLookupStart":734.2000002861023,"fetchStart":734.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":734.2000002861023,"responseEnd":1029.5,"responseStart":1029.5,"secureConnectionStart":734.2000002861023}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":15,"responseStart":166,"responseEnd":172,"domLoading":169,"domInteractive":1327,"domContentLoadedEventStart":1327,"domContentLoadedEventEnd":1373,"domComplete":3243,"loadEventStart":3243,"loadEventEnd":3245,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1312.9000000953674},{"name":"bigPipe.sidebar-id.end","time":1313.7000002861023},{"name":"bigPipe.activity-panel-pipe-id.start","time":1313.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":1316.3000001907349},{"name":"activityTabFullyLoaded","time":1382.4000000953674}],"measures":[],"correlationId":"318e9369d1bc7d","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":86,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}