Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12994

innodb_fast_shutdown=0 skips change buffer merge; fast shutdown does it

    Details

      Description

      The fix for MDEV-12052 contained an error: a full change buffer merge is performed on a fast shutdown only, not on a slow shutdown.
      The following fix should be applied to both InnoDB and XtraDB:

      diff --git a/storage/innobase/srv/srv0srv.cc b/storage/innobase/srv/srv0srv.cc
      index 93ed302a236..bad1579070c 100644
      --- a/storage/innobase/srv/srv0srv.cc
      +++ b/storage/innobase/srv/srv0srv.cc
      @@ -2403,7 +2403,7 @@ DECLARE_THREAD(srv_master_thread)(
       	case SRV_SHUTDOWN_CLEANUP:
       		if (srv_shutdown_state == SRV_SHUTDOWN_CLEANUP
       		    && srv_fast_shutdown < 2) {
      -			srv_shutdown(srv_fast_shutdown == 1);
      +			srv_shutdown(srv_fast_shutdown == 0);
       		}
       		srv_suspend_thread(slot);
       		my_thread_end();
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                marko Marko Mäkelä
                Reporter:
                marko Marko Mäkelä
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: