Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.1.24
-
None
Description
The fix for MDEV-12052 contained an error: a full change buffer merge is performed on a fast shutdown only, not on a slow shutdown.
The following fix should be applied to both InnoDB and XtraDB:
diff --git a/storage/innobase/srv/srv0srv.cc b/storage/innobase/srv/srv0srv.cc
|
index 93ed302a236..bad1579070c 100644
|
--- a/storage/innobase/srv/srv0srv.cc
|
+++ b/storage/innobase/srv/srv0srv.cc
|
@@ -2403,7 +2403,7 @@ DECLARE_THREAD(srv_master_thread)(
|
case SRV_SHUTDOWN_CLEANUP:
|
if (srv_shutdown_state == SRV_SHUTDOWN_CLEANUP
|
&& srv_fast_shutdown < 2) {
|
- srv_shutdown(srv_fast_shutdown == 1);
|
+ srv_shutdown(srv_fast_shutdown == 0);
|
}
|
srv_suspend_thread(slot);
|
my_thread_end(); |
Attachments
Issue Links
- is caused by
-
MDEV-12052 Shutdown crash presumably due to master thread activity
- Closed
- relates to
-
MDEV-13039 innodb_fast_shutdown=0 may fail to purge all undo logs
- Closed