Type:
Task
Priority:
Major
Resolution:
Fixed
This code in item.cc is not friendly to pluggable data types:
void Item_type_holder::get_full_info(Item *item)
{
if (Item_type_holder::real_type_handler() == &type_handler_enum ||
Item_type_holder::real_type_handler() == &type_handler_set)
{
if (item->type() == Item::SUM_FUNC_ITEM &&
(((Item_sum*)item)->sum_func() == Item_sum::MAX_FUNC ||
((Item_sum*)item)->sum_func() == Item_sum::MIN_FUNC))
item = ((Item_sum*)item)->get_arg(0);
/*
We can have enum/set type after merging only if we have one enum|set
field (or MIN|MAX(enum|set field)) and number of NULL fields
*/
DBUG_ASSERT((enum_set_typelib &&
item->real_type_handler() == &type_handler_null) ||
(!enum_set_typelib &&
item->real_item()->type() == Item::FIELD_ITEM &&
(item->real_type_handler() == &type_handler_enum ||
item->real_type_handler() == &type_handler_set) &&
((Field_enum*)((Item_field *) item->real_item())->field)->typelib;
if (!enum_set_typelib)
{
enum_set_typelib= ((Field_enum*)((Item_field *) item->real_item())->field)
}
}
}
Unlike ENUM and SET , new TYPELIB -based data types may want to preserve the exact data type hybrid functions like CASE or LEAST .
Instead of having this hard-coded logic that preserves TYPELIB only in UNION and only for fields and aggregate functions MIN(field) and MAX(field) , will introduce new methods:
virtual TYPELIB *Field::get_typelib() const ;
virtual TYPELIB *Item::get_typelib() const ;
and decompose this code into virtual implementations in Field , Field_enum , Item_field , Item_ref , Item_sum_hybrid .
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":919.5,"ttfb":255.10000038146973,"pageVisibility":"visible","entityId":61297,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"ef63a397-7306-434c-98d9-a00c76773a57","navigationType":0,"readyForUser":1054.1999998092651,"redirectCount":0,"resourceLoadedEnd":651.8999996185303,"resourceLoadedStart":263.30000019073486,"resourceTiming":[{"duration":66.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":263.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":263.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":330.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":67,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":263.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":263.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":330.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":276.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":263.8999996185303,"connectEnd":332.69999980926514,"connectStart":332.69999980926514,"domainLookupEnd":332.69999980926514,"domainLookupStart":332.69999980926514,"fetchStart":263.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":333,"responseEnd":540.5,"responseStart":347.6000003814697,"secureConnectionStart":332.69999980926514},{"duration":387.29999923706055,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":264.6000003814697,"connectEnd":264.6000003814697,"connectStart":264.6000003814697,"domainLookupEnd":264.6000003814697,"domainLookupStart":264.6000003814697,"fetchStart":264.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":336.19999980926514,"responseEnd":651.8999996185303,"responseStart":353.8999996185303,"secureConnectionStart":264.6000003814697},{"duration":100.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":264.80000019073486,"connectEnd":264.80000019073486,"connectStart":264.80000019073486,"domainLookupEnd":264.80000019073486,"domainLookupStart":264.80000019073486,"fetchStart":264.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":337.80000019073486,"responseEnd":365,"responseStart":362.69999980926514,"secureConnectionStart":264.80000019073486},{"duration":102.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":265,"connectEnd":265,"connectStart":265,"domainLookupEnd":265,"domainLookupStart":265,"fetchStart":265,"redirectEnd":0,"redirectStart":0,"requestStart":338,"responseEnd":367.30000019073486,"responseStart":363.30000019073486,"secureConnectionStart":265},{"duration":103.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":265.19999980926514,"connectEnd":265.19999980926514,"connectStart":265.19999980926514,"domainLookupEnd":265.19999980926514,"domainLookupStart":265.19999980926514,"fetchStart":265.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":338.19999980926514,"responseEnd":368.80000019073486,"responseStart":365.19999980926514,"secureConnectionStart":265.19999980926514},{"duration":72,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":265.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":265.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":337.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":105,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":265.5,"connectEnd":265.5,"connectStart":265.5,"domainLookupEnd":265.5,"domainLookupStart":265.5,"fetchStart":265.5,"redirectEnd":0,"redirectStart":0,"requestStart":341,"responseEnd":370.5,"responseStart":366.19999980926514,"secureConnectionStart":265.5},{"duration":73.09999942779541,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":265.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":265.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":338.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":106.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":265.8999996185303,"connectEnd":265.8999996185303,"connectStart":265.8999996185303,"domainLookupEnd":265.8999996185303,"domainLookupStart":265.8999996185303,"fetchStart":265.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":348.6000003814697,"responseEnd":372.6000003814697,"responseStart":369.30000019073486,"secureConnectionStart":265.8999996185303},{"duration":376.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":269.30000019073486,"connectEnd":269.30000019073486,"connectStart":269.30000019073486,"domainLookupEnd":269.30000019073486,"domainLookupStart":269.30000019073486,"fetchStart":269.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":466.5,"responseEnd":646.1000003814697,"responseStart":643.6000003814697,"secureConnectionStart":269.30000019073486},{"duration":379,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":269.3999996185303,"connectEnd":269.3999996185303,"connectStart":269.3999996185303,"domainLookupEnd":269.3999996185303,"domainLookupStart":269.3999996185303,"fetchStart":269.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":574.3000001907349,"responseEnd":648.3999996185303,"responseStart":645.3999996185303,"secureConnectionStart":269.3999996185303},{"duration":130,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":673.5,"connectEnd":673.5,"connectStart":673.5,"domainLookupEnd":673.5,"domainLookupStart":673.5,"fetchStart":673.5,"redirectEnd":0,"redirectStart":0,"requestStart":766.3000001907349,"responseEnd":803.5,"responseStart":802.8000001907349,"secureConnectionStart":673.5}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":83,"responseStart":255,"responseEnd":269,"domLoading":258,"domInteractive":1108,"domContentLoadedEventStart":1108,"domContentLoadedEventEnd":1156,"domComplete":2349,"loadEventStart":2349,"loadEventEnd":2350,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1092},{"name":"bigPipe.sidebar-id.end","time":1092.8999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":1093},{"name":"bigPipe.activity-panel-pipe-id.end","time":1093.8999996185303},{"name":"activityTabFullyLoaded","time":1169.5}],"measures":[],"correlationId":"e6937c5c44823f","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":98,"dbReadsTimeInMs":14,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Pushed into bb-10.2-ext