-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
The code in Item::decimal_precision():
uint Item::decimal_precision() const
|
{
|
Item_result restype= result_type();
|
|
if ((restype == DECIMAL_RESULT) || (restype == INT_RESULT))
|
{
|
uint prec=
|
my_decimal_length_to_precision(max_char_length(), decimals,
|
unsigned_flag);
|
return MY_MIN(prec, DECIMAL_MAX_PRECISION);
|
}
|
uint res= max_char_length();
|
/*
|
Return at least one decimal digit, even if Item::max_char_length()
|
returned 0. This is important to avoid attempts to create fields of types
|
INT(0) or DECIMAL(0,0) when converting NULL or empty strings to INT/DECIMAL:
|
CREATE TABLE t1 AS SELECT CONVERT(NULL,SIGNED) AS a;
|
*/
|
return res ? MY_MIN(res, DECIMAL_MAX_PRECISION) : 1;
|
}
|
|
- is not friendly to pluggable types
- does not handle temporal types properly (e.g.
MDEV-12769)
We'll introduce a new method in Type_handler:
virtual uint Item_decimal_precision(const Item *item) const;
|
and split Item::decimal_precision() into implementations of the relevant Type_handler_xxx.
The implementation of Item::decimal_precision() will change to:
virtual uint decimal_precision() const
{
return type_handler()->Item_decimal_precision(this);
}
{cpp}
{"report":{"fcp":1528.5,"ttfb":232.69999980926514,"pageVisibility":"visible","entityId":61294,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"956a44e2-80cd-4688-9bab-ba7708c4f575","navigationType":0,"readyForUser":1676.8999996185303,"redirectCount":0,"resourceLoadedEnd":1167.1999998092651,"resourceLoadedStart":272.69999980926514,"resourceTiming":[{"duration":81.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":272.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":272.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":354.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":91,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":272.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":272.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":363.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":715.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":273.09999990463257,"connectEnd":273.09999990463257,"connectStart":273.09999990463257,"domainLookupEnd":273.09999990463257,"domainLookupStart":273.09999990463257,"fetchStart":273.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":366,"responseEnd":988.7999997138977,"responseStart":512.5,"secureConnectionStart":273.09999990463257},{"duration":893.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":273.2999997138977,"connectEnd":273.2999997138977,"connectStart":273.2999997138977,"domainLookupEnd":273.2999997138977,"domainLookupStart":273.2999997138977,"fetchStart":273.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":386.7999997138977,"responseEnd":1167.1999998092651,"responseStart":530,"secureConnectionStart":273.2999997138977},{"duration":342.8999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":273.5,"connectEnd":273.5,"connectStart":273.5,"domainLookupEnd":273.5,"domainLookupStart":273.5,"fetchStart":273.5,"redirectEnd":0,"redirectStart":0,"requestStart":387.09999990463257,"responseEnd":616.3999996185303,"responseStart":564.6999998092651,"secureConnectionStart":273.5},{"duration":360.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":273.59999990463257,"connectEnd":273.59999990463257,"connectStart":273.59999990463257,"domainLookupEnd":273.59999990463257,"domainLookupStart":273.59999990463257,"fetchStart":273.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":387.5,"responseEnd":634.2999997138977,"responseStart":610.5,"secureConnectionStart":273.59999990463257},{"duration":360.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":273.8999996185303,"connectEnd":273.8999996185303,"connectStart":273.8999996185303,"domainLookupEnd":273.8999996185303,"domainLookupStart":273.8999996185303,"fetchStart":273.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":387.69999980926514,"responseEnd":634.5,"responseStart":612.5999999046326,"secureConnectionStart":273.8999996185303},{"duration":90.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":274,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":274,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":364.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":368.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":274.19999980926514,"connectEnd":274.19999980926514,"connectStart":274.19999980926514,"domainLookupEnd":274.19999980926514,"domainLookupStart":274.19999980926514,"fetchStart":274.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":416.3999996185303,"responseEnd":642.3999996185303,"responseStart":639,"secureConnectionStart":274.19999980926514},{"duration":89.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":274.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":274.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":364.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":460.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":274.5,"connectEnd":274.5,"connectStart":274.5,"domainLookupEnd":274.5,"domainLookupStart":274.5,"fetchStart":274.5,"redirectEnd":0,"redirectStart":0,"requestStart":418.19999980926514,"responseEnd":734.6999998092651,"responseStart":640.2999997138977,"secureConnectionStart":274.5},{"duration":852.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":275.59999990463257,"connectEnd":275.59999990463257,"connectStart":275.59999990463257,"domainLookupEnd":275.59999990463257,"domainLookupStart":275.59999990463257,"fetchStart":275.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":479.69999980926514,"responseEnd":1128.5,"responseStart":1116.5,"secureConnectionStart":275.59999990463257},{"duration":855.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":275.59999990463257,"connectEnd":275.59999990463257,"connectStart":275.59999990463257,"domainLookupEnd":275.59999990463257,"domainLookupStart":275.59999990463257,"fetchStart":275.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":527.8999996185303,"responseEnd":1130.6999998092651,"responseStart":1119.0999999046326,"secureConnectionStart":275.59999990463257},{"duration":195.60000038146973,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1129.3999996185303,"connectEnd":1129.3999996185303,"connectStart":1129.3999996185303,"domainLookupEnd":1129.3999996185303,"domainLookupStart":1129.3999996185303,"fetchStart":1129.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":1290.8999996185303,"responseEnd":1325,"responseStart":1323,"secureConnectionStart":1129.3999996185303}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":52,"responseStart":232,"responseEnd":295,"domLoading":252,"domInteractive":1755,"domContentLoadedEventStart":1755,"domContentLoadedEventEnd":1809,"domComplete":2978,"loadEventStart":2978,"loadEventEnd":2978,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1721.8999996185303},{"name":"bigPipe.sidebar-id.end","time":1722.7999997138977},{"name":"bigPipe.activity-panel-pipe-id.start","time":1723},{"name":"bigPipe.activity-panel-pipe-id.end","time":1723.8999996185303},{"name":"activityTabFullyLoaded","time":1833}],"measures":[],"correlationId":"1a1aa2f9c21b5d","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":13,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Pushed to bb-10.2-ext