Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12506

Split Item_func_min_max::fix_length_and_dec() into methods in Type_handler

Details

    Description

      Item_func_min_max::fix_length_and_dec() is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions LEAST and GREATEST, we'll move the code to Type_handler as follows:

      1. Add a new method in Type_handler_hybrid_field_type:

      bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);

      This method will decide which data type handler should be used for the result of LEAST/GREATEST.

      2. Add a new virtual method in Type_handler:

      virtual bool Item_func_min_max_fix_attributes(THD *thd,
      		 
                                                    Item_func_min_max *func,
      		 
                                                    Item **items,
      		 
                                                     uint nitems) const;

      This method will calculate the data type attributes. See Type_std_attributes.

      Note, implementations for the particular Type_handler_xxx classes should reuse the code from Item_hybrid_func_fix_attributes as much as possible, because the current implementation of Item_func_min_max::fix_length_and_dec() is quite buggy:

      • MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
      • MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
      • MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

      Sharing the code with Item_hybrid_func should fix these problems.

      3. Remove the current implementation of Item_func_min_max::fix_length_and_dec() and replace it to the new methods.

      Under terms of this task we'll also disallow LEAST and GREATEST to have arguments of the GEOMETRY data type mixed with numeric and temporal arguments, as this has no sense.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description {{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool
            Type_handler_hybrid_field_type::aggregate_for_min_max(const char *funcname,
                                                                  Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.
            		{{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.
            bar Alexander Barkov made changes -
            Description {{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.
            		{{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.

            Under terms of this task we'll also disallow {{LEAST}} and {{GREATEST}} to have arguments of the {{GEOMETRY}} data type mixed with numeric and temporal arguments.

            bar Alexander Barkov made changes -
            Description {{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.

            Under terms of this task we'll also disallow {{LEAST}} and {{GREATEST}} to have arguments of the {{GEOMETRY}} data type mixed with numeric and temporal arguments.

            		{{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.

            Under terms of this task we'll also disallow {{LEAST}} and {{GREATEST}} to have arguments of the {{GEOMETRY}} data type mixed with numeric and temporal arguments, as this has not sense.

            bar Alexander Barkov made changes -
            Description {{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.

            Under terms of this task we'll also disallow {{LEAST}} and {{GREATEST}} to have arguments of the {{GEOMETRY}} data type mixed with numeric and temporal arguments, as this has not sense.

            		{{Item_func_min_max::fix_length_and_dec()}} is hard-coded for the built-in data types. To allow pluggable data type determine behavior of the functions {{LEAST}} and {{GREATEST}}, we'll move the code to {{Type_handler}} as follows:

            1. Add a new method in {{Type_handler_hybrid_field_type}}:

            {code:cpp}
            bool aggregate_for_min_max(const char *funcname, Item **items, uint nitems);
            {code}

            This method will decide which data type handler should be used for the result of {{LEAST}}/{{GREATEST}}.


            2. Add a new virtual method in {{Type_handler}}:
            {code:cpp}
            virtual bool Item_func_min_max_fix_attributes(THD *thd,
                                                          Item_func_min_max *func,
                                                          Item **items,
                                                           uint nitems) const;
            {code}
            This method will calculate the data type attributes. See {{Type_std_attributes}}.

            Note, implementations for the particular {{Type_handler_xxx}} classes should reuse the code from {{Item_hybrid_func_fix_attributes}} as much as possible, because the current implementation of {{Item_func_min_max::fix_length_and_dec()}} is quite buggy:

            - MDEV-12497 Wrong data type for LEAST(latin1_expr, utf8_expr)
            - MDEV-12504 Wrong data type for LEAST(date_expr,time_expr)
            - MDEV-12505 Wrong data type for GREATEST(bit_column, int_column)

            Sharing the code with {{Item_hybrid_func}} should fix these problems.

            3. Remove the current implementation of {{Item_func_min_max::fix_length_and_dec()}} and replace it to the new methods.

            Under terms of this task we'll also disallow {{LEAST}} and {{GREATEST}} to have arguments of the {{GEOMETRY}} data type mixed with numeric and temporal arguments, as this has no sense.

            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Alexey Botchkov [ holyfoot ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            holyfoot Alexey Botchkov added a comment -

            Ok to push.

            holyfoot Alexey Botchkov added a comment - Ok to push.
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov added a comment -

            Pushed to bb-10.2-ext

            bar Alexander Barkov added a comment - Pushed to bb-10.2-ext
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.1 [ 22532 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 80329 ] MariaDB v4 [ 133208 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.