Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12469

FTBFS, compile time error with GCC7

Details

    Description

      Hello,
      I encountered some compile time errors while compiling with GCC7, because (most probabbly) come standards doesn't allow ceratin operation anymore.

      /builddir/build/BUILD/mariadb-10.2.5/storage/innobase/fil/fil0crypt.cc: In function 'void fil_crypt_rotate_page(const key_state_t*, rotate_thread_t*)':
      		 
      /builddir/build/BUILD/mariadb-10.2.5/storage/innobase/fil/fil0crypt.cc:1770:15: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
      		 
        if (space == TRX_SYS_SPACE && offset == TRX_SYS_PAGE_NO) {
      		 
                     ^~~~~~~~~~~~~


      /builddir/build/BUILD/mariadb-10.2.5/sql/sql_get_diagnostics.cc
      		 
      /builddir/build/BUILD/mariadb-10.2.5/storage/innobase/fil/fil0crypt.cc: In function 'void fil_crypt_rotate_page(const key_state_t*, rotate_thread_t*)':
      		 
      /builddir/build/BUILD/mariadb-10.2.5/storage/innobase/fil/fil0crypt.cc:1770:15: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
      		 
        if (space == TRX_SYS_SPACE && offset == TRX_SYS_PAGE_NO) {
      		 
                     ^~~~~~~~~~~~~

      Here's the full build log.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13337 Compile error: mysys_ssl/openssl.c:37:1: error: parameter name omitted

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12474 Rocksdb - failing tests

          • Major - Major loss of function.
          • Closed
          links to

          Web Link rocksdb upstream bug for static_assert

          Web Link upstream fix for -Wint-in-bool-contex fix for rdb_datadic.cc

          Web Link Upststream rocksdb PPC64BE facebook/mysql-5.6#600

          Activity

            Ascending order - Click to sort in descending order
            View 21 older comments
            serg Sergei Golubchik added a comment -

            Described in what comment? I suspect you have the wrong link. The comment you've mentioned was already after 10.2.7 is released (you say there "I just saw MariaDB 10.2.7 is available, so i tried it").

            serg Sergei Golubchik added a comment - Described in what comment? I suspect you have the wrong link. The comment you've mentioned was already after 10.2.7 is released (you say there "I just saw MariaDB 10.2.7 is available, so i tried it").
            mschorm Michal Schorm added a comment -

            Oh, now I see. I thought I built last time 10.2.6, but it looks like I built with 10.2.7 both times.
            Ok, let's just jake it as an confirmation

            mschorm Michal Schorm added a comment - Oh, now I see. I thought I built last time 10.2.6, but it looks like I built with 10.2.7 both times. Ok, let's just jake it as an confirmation
            serg Sergei Golubchik added a comment -

            Just tested with gcc-7.1.0 — all compiles fine. There are warnings, but I'll fix them in MDEV-13459 (needs to be done starting from 5.5)

            serg Sergei Golubchik added a comment - Just tested with gcc-7.1.0 — all compiles fine. There are warnings, but I'll fix them in MDEV-13459 (needs to be done starting from 5.5)
            serg Sergei Golubchik added a comment -

            In fact, only 10.1 compiles, 10.2 doesn't.

            Fails when compiling AWS SDK — it enables -Werror and fails on "may fall-through". AWS SDK is not part of the source tree, it's downloaded as needed. I guess, we need to switch to a newer version of AWS SDK where this is fixed. This failure doesn't affect Fedora, as you don't download AWS SDK during the build.

            serg Sergei Golubchik added a comment - In fact, only 10.1 compiles, 10.2 doesn't. Fails when compiling AWS SDK — it enables -Werror and fails on "may fall-through". AWS SDK is not part of the source tree, it's downloaded as needed. I guess, we need to switch to a newer version of AWS SDK where this is fixed. This failure doesn't affect Fedora, as you don't download AWS SDK during the build.
            wlad Vladislav Vaintroub added a comment -

            Fixed AWS SDK version

            wlad Vladislav Vaintroub added a comment - Fixed AWS SDK version

            People

              wlad Vladislav Vaintroub
              mschorm Michal Schorm
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.