Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12271

port Bug#23150562 REMOVE UNIV_MUST_NOT_INLINE AND UNIV_NONINL

Details

    Description

      Also, remove empty .ic files that were not removed by my MySQL commit.

      Problem:

      InnoDB used to support a compilation mode that allowed to choose whether the function definitions in .ic files are to be inlined or not. This stopped making sense when InnoDB moved to C++ in MySQL 5.6 (and ha_innodb.cc started to #include .ic files), and more so in MySQL 5.7 when inline methods and functions were introduced in .h files.

      Solution:

      Remove all references to UNIV_NONINL and UNIV_MUST_NOT_INLINE from all files, assuming that the symbols are never defined. Remove the files fut0fut.cc and ut0byte.cc which only mattered when UNIV_NONINL was defined.

      Attachments

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Marko Mäkelä made transition -
            Open In Progress
            1d 4h 17m 1
            Marko Mäkelä made transition -
            In Progress In Review
            42s 1
            Jan Lindström (Inactive) made transition -
            In Review Stalled
            3h 19m 1
            Marko Mäkelä made transition -
            Stalled Closed
            19h 19m 1

            People

              marko Marko Mäkelä
              ratzpo Rasmus Johansson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.