Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12270

port Bug#21141390 REMOVE UNUSED FUNCTIONS AND CONVERT GLOBAL SYMBOLS TO STATIC

Details

    Description

      InnoDB defines some functions that are not called at all. Other functions are called, but only from the same compilation unit.

      Remove some function declarations and definitions, and add 'static' keywords. Some symbols must be kept for separately compiled tools, such as innochecksum.

      Also, port the follow-up by Jon Olav Hauglid:

      Bug#21153166: REMOVE UNUSED VARIABLES AND CONVERT GLOBAL SYMBOLS TO STATIC

      Follow-up to
      Bug#21141390: REMOVE UNUSED FUNCTIONS AND CONVERT GLOBAL SYMBOLS TO STATIC
      but for variables instead of functions.

      Was identified with the -Wmissing-variable-declarations
      compiler warning option supported by Clang 3.6.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          ratzpo Rasmus Johansson (Inactive) created issue -
          ratzpo Rasmus Johansson (Inactive) made changes -
          Field Original Value New Value
          Epic Link MDEV-12265 [ 60576 ]
          marko Marko Mäkelä made changes -
          Fix Version/s 10.2.5 [ 22117 ]
          marko Marko Mäkelä made changes -
          Component/s Storage Engine - InnoDB [ 10129 ]
          marko Marko Mäkelä made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          marko Marko Mäkelä made changes -
          Description InnoDB defines some functions that are not called at all. Other functions are called, but only from the same compilation unit.

          Remove some function declarations and definitions, and add 'static' keywords. Some symbols must be kept for separately compiled tools, such as innochecksum.

          Also, port [the follow-up by Jon Olav Hauglid|https://github.com/mysql/mysql-server/commit/4718005900abdb28e054210be4cc77119e4539e9]:

          Bug#21153166: REMOVE UNUSED VARIABLES AND CONVERT GLOBAL SYMBOLS TO STATIC
              
          Follow-up to
          Bug#21141390: REMOVE UNUSED FUNCTIONS AND CONVERT GLOBAL SYMBOLS TO STATIC
          but for variables instead of functions.
              
          Was identified with the -Wmissing-variable-declarations
          compiler warning option supported by Clang 3.6.
          marko Marko Mäkelä added a comment -

          bb-10.2-marko~ and bb-10.2-marko

          marko Marko Mäkelä added a comment - bb-10.2-marko~ and bb-10.2-marko
          marko Marko Mäkelä made changes -
          Assignee Marko Mäkelä [ marko ] Jan Lindström [ jplindst ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          jplindst Jan Lindström (Inactive) added a comment -

          ok to push.

          jplindst Jan Lindström (Inactive) added a comment - ok to push.
          jplindst Jan Lindström (Inactive) made changes -
          Assignee Jan Lindström [ jplindst ] Marko Mäkelä [ marko ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          marko Marko Mäkelä made changes -
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 79987 ] MariaDB v4 [ 133170 ]

          People

            marko Marko Mäkelä
            ratzpo Rasmus Johansson (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.