Type:
Task
Priority:
Major
Resolution:
Fixed
InnoDB defines some functions that are not called at all. Other functions are called, but only from the same compilation unit.
Remove some function declarations and definitions, and add 'static' keywords. Some symbols must be kept for separately compiled tools, such as innochecksum.
Also, port the follow-up by Jon Olav Hauglid :
Bug#21153166: REMOVE UNUSED VARIABLES AND CONVERT GLOBAL SYMBOLS TO STATIC
Follow-up to
Bug#21141390: REMOVE UNUSED FUNCTIONS AND CONVERT GLOBAL SYMBOLS TO STATIC
but for variables instead of functions.
Was identified with the -Wmissing-variable-declarations
compiler warning option supported by Clang 3.6.
{"report":{"fcp":1193,"ttfb":415.6000003814697,"pageVisibility":"visible","entityId":60581,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"144600dc-9a2c-44d5-9fb7-d8290b2dcb7d","navigationType":0,"readyForUser":1303.7000002861023,"redirectCount":0,"resourceLoadedEnd":1364.8000001907349,"resourceLoadedStart":421.80000019073486,"resourceTiming":[{"duration":208.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":421.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":421.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":630.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":208.2999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":422.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":422.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":630.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":217.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":422.30000019073486,"connectEnd":422.30000019073486,"connectStart":422.30000019073486,"domainLookupEnd":422.30000019073486,"domainLookupStart":422.30000019073486,"fetchStart":422.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":422.30000019073486,"responseEnd":640,"responseStart":640,"secureConnectionStart":422.30000019073486},{"duration":315.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":422.5,"connectEnd":422.5,"connectStart":422.5,"domainLookupEnd":422.5,"domainLookupStart":422.5,"fetchStart":422.5,"redirectEnd":0,"redirectStart":0,"requestStart":422.5,"responseEnd":738.1000003814697,"responseStart":738.1000003814697,"secureConnectionStart":422.5},{"duration":319.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":422.7000002861023,"connectEnd":422.7000002861023,"connectStart":422.7000002861023,"domainLookupEnd":422.7000002861023,"domainLookupStart":422.7000002861023,"fetchStart":422.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":422.7000002861023,"responseEnd":742.5,"responseStart":742.5,"secureConnectionStart":422.7000002861023},{"duration":320,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":422.90000009536743,"connectEnd":422.90000009536743,"connectStart":422.90000009536743,"domainLookupEnd":422.90000009536743,"domainLookupStart":422.90000009536743,"fetchStart":422.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":422.90000009536743,"responseEnd":742.9000000953674,"responseStart":742.8000001907349,"secureConnectionStart":422.90000009536743},{"duration":386.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":423.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":423.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":809.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":320.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":423.1000003814697,"connectEnd":423.1000003814697,"connectStart":423.1000003814697,"domainLookupEnd":423.1000003814697,"domainLookupStart":423.1000003814697,"fetchStart":423.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":423.1000003814697,"responseEnd":743.4000000953674,"responseStart":743.4000000953674,"secureConnectionStart":423.1000003814697},{"duration":320.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":423.40000009536743,"connectEnd":423.40000009536743,"connectStart":423.40000009536743,"domainLookupEnd":423.40000009536743,"domainLookupStart":423.40000009536743,"fetchStart":423.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":423.40000009536743,"responseEnd":744,"responseStart":744,"secureConnectionStart":423.40000009536743},{"duration":386,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":423.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":423.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":809.5,"responseStart":0,"secureConnectionStart":0},{"duration":321,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":423.6000003814697,"connectEnd":423.6000003814697,"connectStart":423.6000003814697,"domainLookupEnd":423.6000003814697,"domainLookupStart":423.6000003814697,"fetchStart":423.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":423.6000003814697,"responseEnd":744.6000003814697,"responseStart":744.6000003814697,"secureConnectionStart":423.6000003814697},{"duration":932.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":432.1000003814697,"connectEnd":432.1000003814697,"connectStart":432.1000003814697,"domainLookupEnd":432.1000003814697,"domainLookupStart":432.1000003814697,"fetchStart":432.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":432.1000003814697,"responseEnd":1364.2000002861023,"responseStart":1364.2000002861023,"secureConnectionStart":432.1000003814697},{"duration":932.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":432.2000002861023,"connectEnd":432.2000002861023,"connectStart":432.2000002861023,"domainLookupEnd":432.2000002861023,"domainLookupStart":432.2000002861023,"fetchStart":432.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":432.2000002861023,"responseEnd":1364.8000001907349,"responseStart":1364.8000001907349,"secureConnectionStart":432.2000002861023},{"duration":283.6000003814697,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":824.5,"connectEnd":824.5,"connectStart":824.5,"domainLookupEnd":824.5,"domainLookupStart":824.5,"fetchStart":824.5,"redirectEnd":0,"redirectStart":0,"requestStart":824.5,"responseEnd":1108.1000003814697,"responseStart":1108.1000003814697,"secureConnectionStart":824.5},{"duration":252.40000009536743,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1184.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1184.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1437.2000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":294.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1219.7000002861023,"connectEnd":1219.7000002861023,"connectStart":1219.7000002861023,"domainLookupEnd":1219.7000002861023,"domainLookupStart":1219.7000002861023,"fetchStart":1219.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":1219.7000002861023,"responseEnd":1514,"responseStart":1514,"secureConnectionStart":1219.7000002861023}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":246,"responseStart":416,"responseEnd":430,"domLoading":420,"domInteractive":1438,"domContentLoadedEventStart":1438,"domContentLoadedEventEnd":1502,"domComplete":1794,"loadEventStart":1794,"loadEventEnd":1795,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1370},{"name":"bigPipe.sidebar-id.end","time":1370.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1371.1000003814697},{"name":"bigPipe.activity-panel-pipe-id.end","time":1372.2000002861023},{"name":"activityTabFullyLoaded","time":1515.6000003814697}],"measures":[],"correlationId":"69febbdc27a388","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":96,"dbReadsTimeInMs":10,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
ok to push.