Type:
Task
Priority:
Major
Resolution:
Fixed
The following methods:
Item_sum_sum::fix_length_and_dec()
Item_sum_avg::fix_length_and_dec()
Item_sum_variance::fix_length_and_dec()
use methods cmp_type() and result_type() of their arguments.
The is not friendly to pluggable data types.
Pluggable data types should be able to define their own fix_length_and_dec() logic.
Under term of this task we'll split implementations of these methods into new methods in Type_handler:
virtual bool Item_sum_sum_fix_length_and_dec(Item_sum_sum *) const ;
virtual bool Item_sum_avg_fix_length_and_dec(Item_sum_avg *) const ;
virtual bool Item_sum_variance_fix_length_and_dec(Item_sum_variance *) const ;
We'll also make the server return an error when a GOMETRY type expression appears as an argument of the affected operations.
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":767,"ttfb":185.20000004768372,"pageVisibility":"visible","entityId":60534,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"e9949094-9d5c-436e-b3e3-4fc0e66c0e7a","navigationType":0,"readyForUser":838.0999999046326,"redirectCount":0,"resourceLoadedEnd":474.2000000476837,"resourceLoadedStart":201.40000009536743,"resourceTiming":[{"duration":40.799999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":201.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":201.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":242.20000004768372,"responseStart":0,"secureConnectionStart":0},{"duration":41,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":201.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":201.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":242.70000004768372,"responseStart":0,"secureConnectionStart":0},{"duration":132.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":201.79999995231628,"connectEnd":201.79999995231628,"connectStart":201.79999995231628,"domainLookupEnd":201.79999995231628,"domainLookupStart":201.79999995231628,"fetchStart":201.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":244.29999995231628,"responseEnd":334.59999990463257,"responseStart":269.5,"secureConnectionStart":201.79999995231628},{"duration":272,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":202.20000004768372,"connectEnd":256,"connectStart":256,"domainLookupEnd":256,"domainLookupStart":256,"fetchStart":202.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":256.2999999523163,"responseEnd":474.2000000476837,"responseStart":271.7000000476837,"secureConnectionStart":256},{"duration":72.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":202.29999995231628,"connectEnd":202.29999995231628,"connectStart":202.29999995231628,"domainLookupEnd":202.29999995231628,"domainLookupStart":202.29999995231628,"fetchStart":202.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":257.2999999523163,"responseEnd":275.09999990463257,"responseStart":273.40000009536743,"secureConnectionStart":202.29999995231628},{"duration":79.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":202.40000009536743,"connectEnd":202.40000009536743,"connectStart":202.40000009536743,"domainLookupEnd":202.40000009536743,"domainLookupStart":202.40000009536743,"fetchStart":202.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":257.90000009536743,"responseEnd":281.90000009536743,"responseStart":278.90000009536743,"secureConnectionStart":202.40000009536743},{"duration":80,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":202.5,"connectEnd":202.5,"connectStart":202.5,"domainLookupEnd":202.5,"domainLookupStart":202.5,"fetchStart":202.5,"redirectEnd":0,"redirectStart":0,"requestStart":260,"responseEnd":282.5,"responseStart":279.59999990463257,"secureConnectionStart":202.5},{"duration":56.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":202.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":202.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":259,"responseStart":0,"secureConnectionStart":0},{"duration":81.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":202.70000004768372,"connectEnd":202.70000004768372,"connectStart":202.70000004768372,"domainLookupEnd":202.70000004768372,"domainLookupStart":202.70000004768372,"fetchStart":202.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":260.40000009536743,"responseEnd":284.09999990463257,"responseStart":280.09999990463257,"secureConnectionStart":202.70000004768372},{"duration":57.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":202.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":202.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":259.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":86.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":202.90000009536743,"connectEnd":202.90000009536743,"connectStart":202.90000009536743,"domainLookupEnd":202.90000009536743,"domainLookupStart":202.90000009536743,"fetchStart":202.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":262.5,"responseEnd":289.40000009536743,"responseStart":283,"secureConnectionStart":202.90000009536743},{"duration":240,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":216.09999990463257,"connectEnd":216.09999990463257,"connectStart":216.09999990463257,"domainLookupEnd":216.09999990463257,"domainLookupStart":216.09999990463257,"fetchStart":216.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":306.5,"responseEnd":456.09999990463257,"responseStart":450.2999999523163,"secureConnectionStart":216.09999990463257},{"duration":241.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":216.09999990463257,"connectEnd":216.09999990463257,"connectStart":216.09999990463257,"domainLookupEnd":216.09999990463257,"domainLookupStart":216.09999990463257,"fetchStart":216.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":325.2000000476837,"responseEnd":457.59999990463257,"responseStart":453.09999990463257,"secureConnectionStart":216.09999990463257},{"duration":71.29999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":474.7000000476837,"connectEnd":474.7000000476837,"connectStart":474.7000000476837,"domainLookupEnd":474.7000000476837,"domainLookupStart":474.7000000476837,"fetchStart":474.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":514.9000000953674,"responseEnd":546,"responseStart":545.2999999523163,"secureConnectionStart":474.7000000476837},{"duration":126.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":689.5,"connectEnd":689.5,"connectStart":689.5,"domainLookupEnd":689.5,"domainLookupStart":689.5,"fetchStart":689.5,"redirectEnd":0,"redirectStart":0,"requestStart":786.7999999523163,"responseEnd":816.4000000953674,"responseStart":815.7999999523163,"secureConnectionStart":689.5},{"duration":142.79999995231628,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":760.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":760.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":903.5,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":48,"responseStart":185,"responseEnd":215,"domLoading":188,"domInteractive":889,"domContentLoadedEventStart":889,"domContentLoadedEventEnd":932,"domComplete":1140,"loadEventStart":1140,"loadEventEnd":1140,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":872.7999999523163},{"name":"bigPipe.sidebar-id.end","time":873.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":873.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":874.4000000953674},{"name":"activityTabFullyLoaded","time":947.9000000953674}],"measures":[],"correlationId":"bdc67473ae7797","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":75,"dbReadsTimeInMs":13,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Pushed to bb-10.2-ext