Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12009

Allow to force kill user threads/query which are flagged as high priority by Galera

Details

    Description

      See also: https://github.com/codership/galera/issues/448

      In some cases Galera can mark a user thread as high priority(TOI DDLs) making it unkillable (with misleading message at MDEV-12008)
      I think it should be allowed a way to kill such thread/query under the responsibility of the DBA.
      Syntax could be:
      KILL [CONNECTION | QUERY] processlist_id [FORCE]

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18464 Port kill_one_trx fixes from 10.4 to 10.1

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            jplindst Jan Lindström (Inactive) added a comment - - edited

            serg Does thd->security_ctx->user_matches(tmp->security_ctx)) match with current user or superuser ?

            jplindst Jan Lindström (Inactive) added a comment - - edited serg Does thd->security_ctx->user_matches(tmp->security_ctx)) match with current user or superuser ?
            serg Sergei Golubchik added a comment -

            thd->security_ctx->user_matches(tmp->security_ctx)) means that thd->security_ctx has the same user as tmp->security_ctx.
            thd->security_ctx is the current user.
            But I don't see how it's relevant for the current issue.

            serg Sergei Golubchik added a comment - thd->security_ctx->user_matches(tmp->security_ctx)) means that thd->security_ctx has the same user as tmp->security_ctx . thd->security_ctx is the current user. But I don't see how it's relevant for the current issue.
            jplindst Jan Lindström (Inactive) added a comment -

            I will allow SUPER to kill both high priority transactions as well as wsrep applier threads as it should be.

            jplindst Jan Lindström (Inactive) added a comment - I will allow SUPER to kill both high priority transactions as well as wsrep applier threads as it should be.
            marko Marko Mäkelä added a comment -

            I reverted this change, because I think that it depends on a correct fix of MDEV-18464.

            marko Marko Mäkelä added a comment - I reverted this change , because I think that it depends on a correct fix of MDEV-18464 .
            jplindst Jan Lindström (Inactive) added a comment -

            Killing wsrep high priority threads is dangerous and could lead to cluster inconsistent state. Thus it should not be allowed.

            jplindst Jan Lindström (Inactive) added a comment - Killing wsrep high priority threads is dangerous and could lead to cluster inconsistent state. Thus it should not be allowed.

            People

              jplindst Jan Lindström (Inactive)
              claudio.nanni Claudio Nanni
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.