Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11963

RPM Lint: script-without-shebang /usr/bin/wsrep_sst_common

Details

    • Bug
    • Status: Closed (View Workflow)
    • Trivial
    • Resolution: Fixed
    • 10.1.21
    • 10.1.25
    • Galera, Server
    • None
    • Fedora 24

    Description

      RPM Lint Error:
      mariadb-server.x86_64: E: script-without-shebang /usr/bin/wsrep_sst_common
      mariadb-server.x86_64: E: script-without-shebang /usr/share/mariadb/maria_add_gis_sp_bootstrap.sql

      Please add the appropriate shebangs.

      Thanks

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          elenst Elena Stepanova added a comment -

          maria_add_gis_sp_bootstrap.sql is an SQL script. Is it picked up because it has #-styled comments?

          elenst Elena Stepanova added a comment - maria_add_gis_sp_bootstrap.sql is an SQL script. Is it picked up because it has # -styled comments?
          mschorm Michal Schorm added a comment -

          How is it run?
          If it's only loaded by some module, or run with "cat maria_add_gis_sp_bootstrap.sql > mysql", then it should not have execute privileges. (Which is mainly the case I wanted to be checked)
          If it's a script, that is run by the interpreter, than it should have a path to it in the shebang.

          However, I'm not sure
          I picked it up to check it, not to "fix it by any means".

          mschorm Michal Schorm added a comment - How is it run? If it's only loaded by some module, or run with "cat maria_add_gis_sp_bootstrap.sql > mysql", then it should not have execute privileges. (Which is mainly the case I wanted to be checked) If it's a script, that is run by the interpreter, than it should have a path to it in the shebang. However, I'm not sure I picked it up to check it, not to "fix it by any means".
          elenst Elena Stepanova added a comment -

          Okay, I see now, so it's picked because it's executable. I think it shouldn't be executable, it looks like it's only used with cat.
          nirbhay_c,
          after dealing with the wsrep one, could you please assign it to holyfoot to check why maria_add_gis_sp_bootstrap.sql and maria_add_gis_sp.sql are executable?

          elenst Elena Stepanova added a comment - Okay, I see now, so it's picked because it's executable. I think it shouldn't be executable, it looks like it's only used with cat . nirbhay_c , after dealing with the wsrep one, could you please assign it to holyfoot to check why maria_add_gis_sp_bootstrap.sql and maria_add_gis_sp.sql are executable?
          nirbhay_c Nirbhay Choubey (Inactive) added a comment -

          holyfoot Can you please review the patch?
          http://lists.askmonty.org/pipermail/commits/2017-February/010594.html

          nirbhay_c Nirbhay Choubey (Inactive) added a comment - holyfoot Can you please review the patch? http://lists.askmonty.org/pipermail/commits/2017-February/010594.html
          holyfoot Alexey Botchkov added a comment -

          http://lists.askmonty.org/pipermail/commits/2017-August/011328.html

          holyfoot Alexey Botchkov added a comment - http://lists.askmonty.org/pipermail/commits/2017-August/011328.html

          People

            holyfoot Alexey Botchkov
            mschorm Michal Schorm
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.