[MDEV-11963] RPM Lint: script-without-shebang /usr/bin/wsrep_sst_common Created: 2017-02-01  Updated: 2017-08-01  Resolved: 2017-08-01

Status: Closed
Project: MariaDB Server
Component/s: Galera, Server
Affects Version/s: 10.1.21
Fix Version/s: 10.1.25

Type: Bug Priority: Trivial
Reporter: Michal Schorm Assignee: Alexey Botchkov
Resolution: Fixed Votes: 0
Labels: None
Environment:

Fedora 24



 Description   

RPM Lint Error:
mariadb-server.x86_64: E: script-without-shebang /usr/bin/wsrep_sst_common
mariadb-server.x86_64: E: script-without-shebang /usr/share/mariadb/maria_add_gis_sp_bootstrap.sql


Please add the appropriate shebangs.

Thanks



 Comments   
Comment by Elena Stepanova [ 2017-02-01 ]

maria_add_gis_sp_bootstrap.sql is an SQL script. Is it picked up because it has #-styled comments?

Comment by Michal Schorm [ 2017-02-01 ]

How is it run?
If it's only loaded by some module, or run with "cat maria_add_gis_sp_bootstrap.sql > mysql", then it should not have execute privileges. (Which is mainly the case I wanted to be checked)
If it's a script, that is run by the interpreter, than it should have a path to it in the shebang.

However, I'm not sure
I picked it up to check it, not to "fix it by any means".

Comment by Elena Stepanova [ 2017-02-01 ]

Okay, I see now, so it's picked because it's executable. I think it shouldn't be executable, it looks like it's only used with cat.
nirbhay_c,
after dealing with the wsrep one, could you please assign it to holyfoot to check why maria_add_gis_sp_bootstrap.sql and maria_add_gis_sp.sql are executable?

Comment by Nirbhay Choubey (Inactive) [ 2017-02-01 ]

holyfoot Can you please review the patch?
http://lists.askmonty.org/pipermail/commits/2017-February/010594.html

Comment by Alexey Botchkov [ 2017-08-01 ]

http://lists.askmonty.org/pipermail/commits/2017-August/011328.html

Generated at Thu Feb 08 07:54:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.