Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11960

[Docs] RPM Lint: incorrect-fsf-address

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Duplicate
    • 10.1.21
    • N/A
    • Documentation
    • None

    Description

      Looks like the URL for the GPL licence is not actual, so tagging as [Docs].
      Feel free to rename it if I am mistaken or assign it to another component.

      ( from https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address )
      *incorrect-fsf-address
      In all cases, upstream should be informed about this. This is the only requirement with respect to this error.
      *

      Example of the error message:
      mariadb-devel.x86_64: E: incorrect-fsf-address /usr/include/mysql/private/my_default.h

      All affected files listed:
      /usr/include/mysql/private/my_default.h
      /usr/include/mysql/private/sql_lifo_buffer.h
      /usr/include/mysql/private/gcalc_tools.h
      /usr/include/mysql/private/myisamchk.h
      /usr/include/mysql/private/wsrep.h
      /usr/include/mysql/private/sql_join_cache.h
      /usr/include/mysql/private/sql_expression_cache.h
      /usr/include/mysql/my_decimal_limits.h
      /usr/include/mysql/little_endian.h
      /usr/include/mysql/byte_order_generic_x86.h
      /usr/include/mysql/private/opt_subselect.h
      /usr/include/mysql/service_progress_report.h
      /usr/include/mysql/private/maria.h
      /usr/include/mysql/private/gcalc_slicescan.h
      /usr/include/mysql/private/sql_analyze_stmt.h
      /usr/include/mysql/auth_dialog_client.h
      /usr/include/mysql/private/winservice.h
      /usr/include/mysql/byte_order_generic_x86_64.h
      /usr/include/mysql/private/create_options.h
      /usr/include/mysql/private/sql_explain.h
      /usr/include/mysql/private/waiting_threads.h
      /usr/include/mysql/private/threadpool.h
      /usr/include/mysql/private/wsrep_priv.h
      /usr/include/mysql/private/my_json_writer.h
      /usr/include/mysql/my_valgrind.h
      /usr/include/mysql/private/multi_range_read.h
      /usr/include/mysql/private/group_by_handler.h
      /usr/include/mysql/private/wqueue.h
      /usr/include/mysql/private/log_slow.h
      /usr/include/mysql/private/my_rnd.h
      /usr/include/mysql/private/my_apc.h
      /usr/include/mysql/private/bounded_queue.h
      /usr/include/mysql/private/sql_get_diagnostics.h
      /usr/include/mysql/service_logger.h
      /usr/include/mysql/private/my_cpu.h
      /usr/include/mysql/private/wsrep_applier.h
      /usr/include/mysql/byte_order_generic.h
      /usr/include/mysql/private/mysql_async.h
      /usr/include/mysql/big_endian.h
      /usr/include/mysql/private/wsrep_mysqld.h

      /usr/share/mysql-test/suite/sys_vars/t/pfs_digests_size_basic.test
      /usr/share/mysql-test/suite/sys_vars/t/pfs_max_digest_length_basic.test
      /usr/share/mysql-test/suite/sys_vars/t/max_digest_length_basic.test

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6867 FSF address is incorrect in some files

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            mschorm Michal Schorm created issue -
            greenman Ian Gilfillan added a comment -

            Can you clarify? I see that some of the files have the old address:
            Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA

            However, some of the files have the new address:
            Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335, USA
            e.g https://github.com/MariaDB/server/blob/10.1/include/big_endian.h

            Is updating the physical address the only thing necessary (so the list of affected files is not accurate), or is there something else?

            greenman Ian Gilfillan added a comment - Can you clarify? I see that some of the files have the old address: Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA However, some of the files have the new address: Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335, USA e.g https://github.com/MariaDB/server/blob/10.1/include/big_endian.h Is updating the physical address the only thing necessary (so the list of affected files is not accurate), or is there something else?
            mschorm Michal Schorm added a comment - - edited

            After some troubles, I, finally, checked it. (sorry for dealy)
            Yes, the only thing to change is the (postal?) address.

            The new version should not be taken as wrong, however, somewhere you have right street, but wrong last number of adress.

            Please, run following above all of the files:

             
            		 
            find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
            		 
            find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
            		 
            find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
            		 
            find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
            		 
             
            		 
            find ./ -type f -exec sed -i -e 's/MA 02111-1307/MA 02111-1301/g' {} \;
            		 
            find ./ -type f -exec sed -i -e 's/MA  02111-1307/MA 02111-1301/g' {} \;

            The correct address (for RPMLint) can be seen here, for example: (I proposed the same change for CONC/C)
            https://github.com/MariaDB/mariadb-connector-c/commit/30614c71e83d639a70d4ed9850b8db06932481e9

            mschorm Michal Schorm added a comment - - edited After some troubles, I, finally, checked it. (sorry for dealy) Yes, the only thing to change is the (postal?) address. The new version should not be taken as wrong, however, somewhere you have right street, but wrong last number of adress. Please, run following above all of the files:   find ./ - type f - exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \; find ./ - type f - exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \; find ./ - type f - exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \; find ./ - type f - exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;   find ./ - type f - exec sed -i -e 's/MA 02111-1307/MA 02111-1301/g' {} \; find ./ - type f - exec sed -i -e 's/MA 02111-1307/MA 02111-1301/g' {} \; The correct address (for RPMLint) can be seen here, for example: (I proposed the same change for CONC/C) https://github.com/MariaDB/mariadb-connector-c/commit/30614c71e83d639a70d4ed9850b8db06932481e9
            greenman Ian Gilfillan made changes -
            Field Original Value New Value
            Fix Version/s 10.1.22 [ 22502 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            greenman Ian Gilfillan made changes -
            greenman Ian Gilfillan made changes -
            Fix Version/s 10.1.22 [ 22502 ]
            greenman Ian Gilfillan added a comment -

            Duplicate, pull request denied, will be handled in MDEV-6867

            greenman Ian Gilfillan added a comment - Duplicate, pull request denied, will be handled in MDEV-6867
            greenman Ian Gilfillan made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Stalled [ 10000 ]
            greenman Ian Gilfillan made changes -
            Assignee Ian Gilfillan [ greenman ]
            elenst Elena Stepanova made changes -
            Fix Version/s N/A [ 14700 ]
            Resolution Duplicate [ 3 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 79468 ] MariaDB v4 [ 151640 ]

            People

              Unassigned Unassigned
              mschorm Michal Schorm
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.