[MDEV-11960] [Docs] RPM Lint: incorrect-fsf-address Created: 2017-02-01  Updated: 2017-03-12  Resolved: 2017-03-12

Status: Closed
Project: MariaDB Server
Component/s: Documentation
Affects Version/s: 10.1.21
Fix Version/s: N/A

Type: Bug Priority: Minor
Reporter: Michal Schorm Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None

Issue Links:
Duplicate
duplicates MDEV-6867 FSF address is incorrect in some files Open

 Description   

Looks like the URL for the GPL licence is not actual, so tagging as [Docs].
Feel free to rename it if I am mistaken or assign it to another component.

( from https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address )
*incorrect-fsf-address
In all cases, upstream should be informed about this. This is the only requirement with respect to this error.
*

Example of the error message:
mariadb-devel.x86_64: E: incorrect-fsf-address /usr/include/mysql/private/my_default.h

All affected files listed:
/usr/include/mysql/private/my_default.h
/usr/include/mysql/private/sql_lifo_buffer.h
/usr/include/mysql/private/gcalc_tools.h
/usr/include/mysql/private/myisamchk.h
/usr/include/mysql/private/wsrep.h
/usr/include/mysql/private/sql_join_cache.h
/usr/include/mysql/private/sql_expression_cache.h
/usr/include/mysql/my_decimal_limits.h
/usr/include/mysql/little_endian.h
/usr/include/mysql/byte_order_generic_x86.h
/usr/include/mysql/private/opt_subselect.h
/usr/include/mysql/service_progress_report.h
/usr/include/mysql/private/maria.h
/usr/include/mysql/private/gcalc_slicescan.h
/usr/include/mysql/private/sql_analyze_stmt.h
/usr/include/mysql/auth_dialog_client.h
/usr/include/mysql/private/winservice.h
/usr/include/mysql/byte_order_generic_x86_64.h
/usr/include/mysql/private/create_options.h
/usr/include/mysql/private/sql_explain.h
/usr/include/mysql/private/waiting_threads.h
/usr/include/mysql/private/threadpool.h
/usr/include/mysql/private/wsrep_priv.h
/usr/include/mysql/private/my_json_writer.h
/usr/include/mysql/my_valgrind.h
/usr/include/mysql/private/multi_range_read.h
/usr/include/mysql/private/group_by_handler.h
/usr/include/mysql/private/wqueue.h
/usr/include/mysql/private/log_slow.h
/usr/include/mysql/private/my_rnd.h
/usr/include/mysql/private/my_apc.h
/usr/include/mysql/private/bounded_queue.h
/usr/include/mysql/private/sql_get_diagnostics.h
/usr/include/mysql/service_logger.h
/usr/include/mysql/private/my_cpu.h
/usr/include/mysql/private/wsrep_applier.h
/usr/include/mysql/byte_order_generic.h
/usr/include/mysql/private/mysql_async.h
/usr/include/mysql/big_endian.h
/usr/include/mysql/private/wsrep_mysqld.h

/usr/share/mysql-test/suite/sys_vars/t/pfs_digests_size_basic.test
/usr/share/mysql-test/suite/sys_vars/t/pfs_max_digest_length_basic.test
/usr/share/mysql-test/suite/sys_vars/t/max_digest_length_basic.test

 Comments   
Comment by Ian Gilfillan [ 2017-02-02 ]

Can you clarify? I see that some of the files have the old address:
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA

However, some of the files have the new address:
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335, USA
e.g https://github.com/MariaDB/server/blob/10.1/include/big_endian.h

Is updating the physical address the only thing necessary (so the list of affected files is not accurate), or is there something else?

Comment by Michal Schorm [ 2017-02-09 ]

After some troubles, I, finally, checked it. (sorry for dealy)
Yes, the only thing to change is the (postal?) address.

The new version should not be taken as wrong, however, somewhere you have right street, but wrong last number of adress.

Please, run following above all of the files:

 
 
find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
 
find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
 
find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
 
find ./ -type f -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA/Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA/g' {} \;
 
 
 
find ./ -type f -exec sed -i -e 's/MA 02111-1307/MA 02111-1301/g' {} \;
 
find ./ -type f -exec sed -i -e 's/MA  02111-1307/MA 02111-1301/g' {} \;

The correct address (for RPMLint) can be seen here, for example: (I proposed the same change for CONC/C)
https://github.com/MariaDB/mariadb-connector-c/commit/30614c71e83d639a70d4ed9850b8db06932481e9

Comment by Ian Gilfillan [ 2017-03-09 ]

Duplicate, pull request denied, will be handled in MDEV-6867

Generated at Thu Feb 08 07:54:00 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.