Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11752

Unsafe strmov - function definition in include/m_string.h

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL)
    • 10.1.22, 10.2.5
    • Server
    • Fedora, RHEL, CentOS
    • 10.1.22

    Description

      Hello,
      I would like to point out this issue, formerly found and solved in MySQL.

      bug#48864
      Please read it through, it is nicely written down.

      In Fedora and RHEL, we still use the same patch, that is pasted in that discussion as "[19 Nov 2009 9:32] Georgi Kodinov"

      —

      Please fill in "Affected component" field, as I am not sure what to choose.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          elenst Elena Stepanova added a comment -

          I'm not sure which current versions of Fedora and server one needs to reproduce the problem; just filling Affects/Fix version guessing from the upstream bug report.

          elenst Elena Stepanova added a comment - I'm not sure which current versions of Fedora and server one needs to reproduce the problem; just filling Affects/Fix version guessing from the upstream bug report.
          mschorm Michal Schorm added a comment - - edited

          Currently, Fedora Rawhide, 25 and 24 contains the same version - MariaDB 10.1.20.
          (And I work on update to 10.1.21 )

          In RHEL other versions are still used too - 5.5, 10.0 and 10.1

          It would be nice to have it fixed in all of theese versions, however the patch works and I'm just trying to point out the issue in order it to be fixed in future releases.

          mschorm Michal Schorm added a comment - - edited Currently, Fedora Rawhide, 25 and 24 contains the same version - MariaDB 10.1.20. (And I work on update to 10.1.21 ) In RHEL other versions are still used too - 5.5, 10.0 and 10.1 It would be nice to have it fixed in all of theese versions, however the patch works and I'm just trying to point out the issue in order it to be fixed in future releases.
          serg Sergei Golubchik added a comment -

          mschorm, is it currently an issue? We have comp_err is fixed, for quite a while, I suspect.

          Are you saying that there are other cases where strmov() is used on overlapping strings?

          serg Sergei Golubchik added a comment - mschorm , is it currently an issue? We have comp_err is fixed, for quite a while, I suspect. Are you saying that there are other cases where strmov() is used on overlapping strings?
          mschorm Michal Schorm added a comment -

          It seems, it is no longer an issue.
          I'm gonna to remove that patch from Fedora.
          You can close this issue.

          Thanks

          I'm trying to refresh the MariaDB and MySQL packages in Fedora, so I'm going through all patches and trying to check, if they are obsolete or should be reported to you and add them to the MariaDB project.

          mschorm Michal Schorm added a comment - It seems, it is no longer an issue. I'm gonna to remove that patch from Fedora. You can close this issue. Thanks I'm trying to refresh the MariaDB and MySQL packages in Fedora, so I'm going through all patches and trying to check, if they are obsolete or should be reported to you and add them to the MariaDB project.
          serg Sergei Golubchik added a comment -

          I've added an assert (in debug builds) that strmov is never used with overlapping strings.

          serg Sergei Golubchik added a comment - I've added an assert (in debug builds) that strmov is never used with overlapping strings.

          People

            serg Sergei Golubchik
            mschorm Michal Schorm
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.