Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11619

mtr: environment MTR_MEM conflicts with --mem

Details

    • 5.5.55, 10.0.30

    Description

      Since 716621db3f3055781e24f561325cec6eac181717, opt_mem is
      a pure flag. However it is assigned to the value of $MTR_MEM.

      This leads to conflicts when MTR_MEM=/xxx/yy ./mtr --mem is
      invoked. Here the --mem option overrided opt_mem leaving the
      default path to be chosen rather than $MTR_MEM.

      Attachments

        Activity

          elenst Elena Stepanova added a comment - https://github.com/MariaDB/server/commit/5e42c958a56f038c51952ddb9464686c1939201b

          I've found the reason why (probably) --mem was made a pure flag. The provided patch breaks common operation.

          If MTR is envoked so that --mem is immediately followed by command-line arguments (test names), the first test is considered to be the value of mem option rather than a test name. The "value" is later ignored because the location of course does not exist, but the test is not executed.

          Example:

          perl ./mysql-test-run.pl --mem 1st alias
          ...
          ==============================================================================
           
          TEST                                      RESULT   TIME (ms) or COMMENT
          --------------------------------------------------------------------------
           
          worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
          main.alias                               [ pass ]     79
          --------------------------------------------------------------------------
          The servers were restarted 0 times
          Spent 0.079 of 5 seconds executing testcases
          

          elenst Elena Stepanova added a comment - I've found the reason why (probably) --mem was made a pure flag. The provided patch breaks common operation. If MTR is envoked so that --mem is immediately followed by command-line arguments (test names), the first test is considered to be the value of mem option rather than a test name. The "value" is later ignored because the location of course does not exist, but the test is not executed. Example: perl ./mysql-test-run.pl --mem 1st alias ... ==============================================================================   TEST RESULT TIME (ms) or COMMENT --------------------------------------------------------------------------   worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 main.alias [ pass ] 79 -------------------------------------------------------------------------- The servers were restarted 0 times Spent 0.079 of 5 seconds executing testcases
          danblack Daniel Black added a comment -

          thanks elenst, fixed in pr #317

          danblack Daniel Black added a comment - thanks elenst , fixed in pr #317

          danblack, see my comment in the PR.

          elenst Elena Stepanova added a comment - danblack , see my comment in the PR.

          The change is partially reverted, --mem is a pure flag again.

          https://github.com/MariaDB/server/commit/b54566d73bb96ef9eb7d734742d3743fb3369a40

          elenst Elena Stepanova added a comment - The change is partially reverted, --mem is a pure flag again. https://github.com/MariaDB/server/commit/b54566d73bb96ef9eb7d734742d3743fb3369a40

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.