Type:
Task
Priority:
Major
Resolution:
Fixed
The method Item_type_holder::display_length(Item *) has this switch :
switch (item->field_type())
This is not friendly to pluggable data types.
We'll introduce a new Type_handler virtual method:
virtual uint32 max_display_length( const Item *item) const ;
and move the pieces from Item_type_holder::display_length(Item *) into implementations of various Type_handler_xxx::max_display_length() .
Additionally, instead of doing cast to Item_field :
uint32 Item_type_holder::display_length(Item *item)
{
if (item->type() == Item::FIELD_ITEM)
return ((Item_field *)item)->max_disp_length();
return ...; // the implementation for non-field Items
}
we'll remove the method Item_type_holder::display_length() and introduce a new virtual method in Item:
virtual uint32 max_display_length() const
{
return type_handler()->max_display_length( this );
}
Notice the default implementation will use max_display_length() of the underlying data type handler.
Item_field will override this implementation and read the result from the underlying field:
uint32 max_display_length() const { return field->max_display_length(); }
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":868.5999999046326,"ttfb":139.39999985694885,"pageVisibility":"visible","entityId":59354,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"0008405b-d23e-4bca-baf9-788554d4c5e5","navigationType":0,"readyForUser":946.1999998092651,"redirectCount":0,"resourceLoadedEnd":983.5999999046326,"resourceLoadedStart":145,"resourceTiming":[{"duration":229.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":145,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":145,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":374.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":229.39999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":145.29999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":145.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":374.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":239,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":145.39999985694885,"connectEnd":145.39999985694885,"connectStart":145.39999985694885,"domainLookupEnd":145.39999985694885,"domainLookupStart":145.39999985694885,"fetchStart":145.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":145.39999985694885,"responseEnd":384.39999985694885,"responseStart":384.39999985694885,"secureConnectionStart":145.39999985694885},{"duration":349.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":145.59999990463257,"connectEnd":145.59999990463257,"connectStart":145.59999990463257,"domainLookupEnd":145.59999990463257,"domainLookupStart":145.59999990463257,"fetchStart":145.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":145.59999990463257,"responseEnd":495.09999990463257,"responseStart":495.09999990463257,"secureConnectionStart":145.59999990463257},{"duration":353,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":145.69999980926514,"connectEnd":145.69999980926514,"connectStart":145.69999980926514,"domainLookupEnd":145.69999980926514,"domainLookupStart":145.69999980926514,"fetchStart":145.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":145.69999980926514,"responseEnd":498.69999980926514,"responseStart":498.69999980926514,"secureConnectionStart":145.69999980926514},{"duration":353.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":145.79999995231628,"connectEnd":145.79999995231628,"connectStart":145.79999995231628,"domainLookupEnd":145.79999995231628,"domainLookupStart":145.79999995231628,"fetchStart":145.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":145.79999995231628,"responseEnd":499.19999980926514,"responseStart":499.19999980926514,"secureConnectionStart":145.79999995231628},{"duration":353.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":145.79999995231628,"connectEnd":145.79999995231628,"connectStart":145.79999995231628,"domainLookupEnd":145.79999995231628,"domainLookupStart":145.79999995231628,"fetchStart":145.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":145.79999995231628,"responseEnd":499.59999990463257,"responseStart":499.59999990463257,"secureConnectionStart":145.79999995231628},{"duration":354.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":145.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":145.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":500.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":354.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":146,"connectEnd":146,"connectStart":146,"domainLookupEnd":146,"domainLookupStart":146,"fetchStart":146,"redirectEnd":0,"redirectStart":0,"requestStart":146,"responseEnd":500.69999980926514,"responseStart":500.69999980926514,"secureConnectionStart":146},{"duration":355,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":146.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":146.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":501.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":355.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":146.29999995231628,"connectEnd":146.29999995231628,"connectStart":146.29999995231628,"domainLookupEnd":146.29999995231628,"domainLookupStart":146.29999995231628,"fetchStart":146.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":146.29999995231628,"responseEnd":501.39999985694885,"responseStart":501.39999985694885,"secureConnectionStart":146.29999995231628},{"duration":504.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":151.5,"connectEnd":151.5,"connectStart":151.5,"domainLookupEnd":151.5,"domainLookupStart":151.5,"fetchStart":151.5,"redirectEnd":0,"redirectStart":0,"requestStart":151.5,"responseEnd":656,"responseStart":656,"secureConnectionStart":151.5},{"duration":831.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":151.69999980926514,"connectEnd":151.69999980926514,"connectStart":151.69999980926514,"domainLookupEnd":151.69999980926514,"domainLookupStart":151.69999980926514,"fetchStart":151.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":151.69999980926514,"responseEnd":983.5999999046326,"responseStart":983.5999999046326,"secureConnectionStart":151.69999980926514},{"duration":118.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":538.7999999523163,"connectEnd":538.7999999523163,"connectStart":538.7999999523163,"domainLookupEnd":538.7999999523163,"domainLookupStart":538.7999999523163,"fetchStart":538.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":538.7999999523163,"responseEnd":657.3999998569489,"responseStart":657.3999998569489,"secureConnectionStart":538.7999999523163},{"duration":226.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":781.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":781.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1007.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":283.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":782.3999998569489,"connectEnd":782.3999998569489,"connectStart":782.3999998569489,"domainLookupEnd":782.3999998569489,"domainLookupStart":782.3999998569489,"fetchStart":782.3999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":782.3999998569489,"responseEnd":1066,"responseStart":1066,"secureConnectionStart":782.3999998569489}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":12,"responseStart":140,"responseEnd":146,"domLoading":143,"domInteractive":1007,"domContentLoadedEventStart":1007,"domContentLoadedEventEnd":1062,"domComplete":2039,"loadEventStart":2039,"loadEventEnd":2041,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":989.5999999046326},{"name":"bigPipe.sidebar-id.end","time":990.3999998569489},{"name":"bigPipe.activity-panel-pipe-id.start","time":990.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":993.2999999523163},{"name":"activityTabFullyLoaded","time":1069.7999999523163}],"measures":[],"correlationId":"4c8191076b34f2","effectiveType":"4g","downlink":9.2,"rtt":0,"serverDuration":74,"dbReadsTimeInMs":9,"dbConnsTimeInMs":16,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}