MDEV-11367 is the same type of bug, different place in the code

I have seen your patch. However, because can be a performance increase, I'd like to make it conditional:

1. Is it only required for double values?
2. can a ArmHF be tested in #if conditions?

Thanks.

For #1: This concerns more than ArmHF unfortunately. We need to check with every platform what kind of restrictions it imposes. Also, it happens with longlong values as well I think, but testing it was very tricky. Check the related MDEV-11367. That patch replaces a longlong pointer dereference.
For #2: Yes

I know that this matter is concerning performance wise, but I'd really want to test this instead of relying on brittle code. It might be that compilers are smart enough to transform memcpy into a pointer dereference anyway.

I can try a micro benchmark to see if this impacts performance or not, but the caveat is that it might not give the full picture depending on various compilers.

I know, the same kind of patch is also needed for MIPS platforms but for all numerical types, not only doubles.

I didn't know about that. Can you link it somehow? Where is it applied? I'm slightly worried that my patch is not complete. I think there are more potential pointer dereferences in the Connect Storage engine but I did not spend too much time to understand the surrounding logic.

There has been a discussion about such problems with MIPS and a proposed patch that was not correct. Looking into the code, I discover another patch that was made by I don't know who, but that I am going to test because it may not be correct in some cases.

The key places to look at are in tabfix.cpp from line 471 and the patch is in value.h line 127.

Vicentiu: I applied your patch plus some more fixes concerning writing in BIN table files.

However this was tested on my machine and on buildbot machines only and apparently none of them have CPU requiring alignment.

So please test if my fixes really work when the new versions will be released and reopen this case if not. Thanks.