Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11330

Split Item_func_hybrid_field_type::val_xxx() into methods in Type_handler

Details

    Description

      Under term of this tasks we'll remove switch(cmp_type()) in Item_func_hybrid_field_type::val_xxx() and Item_func_hybrid_field_type::get_date() and introduce instead new methods in Type_handler, e.g.:

      class Type_handler
      		 
      {
      		 
        ...
      		 
        virtual
      		 
        String *Item_func_hybrid_field_type_val_str(Item_func_hybrid_field_type *,
      		 
                                                      String *) const= 0;};
      		 
      }

      The methods Item_func_hybrid_field_type::val_xxx() and Item_func_hybrid_field_type::get_date() will call the corresponding new methods in Type_handler:

      class Item_func_hybrid_field_type: public Item_hybrid_func
      		 
      {
      		 
        ...
      		 
        String *val_str(String*str)
      		 
        {
      		 
          return Item_func_hybrid_field_type::type_handler()->
      		 
                     Item_func_hybrid_field_type_val_str(this, str);
      		 
        }
      		 
        ...
      		 
      }

      For performance purposes, the change should try not to introduce new virtual calls.
      One virtual call in switch(cmp_type()) should be replaced to one virtual call in Type_handler.
      Calls inside the new methods in Type_handler should be done statically.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Affects Version/s 10.3 [ 22126 ]
            Issue Type Bug [ 1 ] Task [ 3 ]
            bar Alexander Barkov made changes -
            Description Under term of this tasks we'll remove switch(cmp_type()) in Item_func_hybrid_field_type::val_xxx() and Item_func_hybrid_field_type::get_date() and introduce instead new methods in Type_handler, e.g.:
            {code:cpp}
            class Type_handler
            {
              ...
              virtual
              String *Item_func_hybrid_field_type_val_str(Item_func_hybrid_field_type *,
                                                            String *) const= 0;};
            }
            {code}

            The methods Item_func_hybrid_field_type::val_xxx() and Item_func_hybrid_field_type::get_date() will call the corresponding new methods in Type_handler:
            {code:cpp}
            class Item_func_hybrid_field_type: public Item_hybrid_func
            {
              ...
              String *val_str(String*str)
              {
                return Item_func_hybrid_field_type::type_handler()->
                           Item_func_hybrid_field_type_val_str(this, str);
              }
              ...
            }
            {code}

            For performance purposes, the change should try not to introduce new virtual calls.
            One virtual call in switch(cmp_type()) should be replaced to one virtual call in Type_handler.
            Calls inside the new methods in Type_handler should be done statically.
            		Under term of this tasks we'll remove {{switch(cmp_type())}} in {{Item_func_hybrid_field_type::val_xxx()}} and {{Item_func_hybrid_field_type::get_date()}} and introduce instead new methods in {{Type_handler}}, e.g.:
            {code:cpp}
            class Type_handler
            {
              ...
              virtual
              String *Item_func_hybrid_field_type_val_str(Item_func_hybrid_field_type *,
                                                            String *) const= 0;};
            }
            {code}

            The methods {{Item_func_hybrid_field_type::val_xxx()}} and {{Item_func_hybrid_field_type::get_date()}} will call the corresponding new methods in {{Type_handler}}:
            {code:cpp}
            class Item_func_hybrid_field_type: public Item_hybrid_func
            {
              ...
              String *val_str(String*str)
              {
                return Item_func_hybrid_field_type::type_handler()->
                           Item_func_hybrid_field_type_val_str(this, str);
              }
              ...
            }
            {code}

            For performance purposes, the change should try not to introduce new virtual calls.
            One virtual call in {{switch(cmp_type())}} should be replaced to one virtual call in {{Type_handler}}.
            Calls inside the new methods in {{Type_handler}} should be done statically.
            bar Alexander Barkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Vicentiu Ciorbaru [ cvicentiu ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            cvicentiu Vicențiu Ciorbaru made changes -
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            Assignee Vicentiu Ciorbaru [ cvicentiu ] Alexander Barkov [ bar ]
            bar Alexander Barkov made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2016-12-05 12:31:49.0 2016-12-05 12:31:49.716
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.0 [ 22127 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            bar Alexander Barkov made changes -
            Labels datatype
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 78414 ] MariaDB v4 [ 133005 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.