Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.1.17, 5.5.51-galera, 10.0.27-galera
-
None
-
Linux
Description
The feature check for "ncat" in the XtraBackup SST scripts only works on CentOS 7, on other distributions it leads to full netcat help output being written to the error log instead.
This is due to the nc version in CentOS 7 writing help output to stdout, while the version in CentOS 6, and in Ubuntu 16.04, write to stderr instead.
Redirecting stderr to stdout with 2>&1 should make the check work for all versions of netcat:
if nc -h 2>&1 | grep -q ncat;then
instead of current
if nc -h | grep -q ncat;then
The feature check for "ncat" only works on CentOS 7, on other distributions it leads to full netcat help output being written to the error log instead.
This is due to the nc version in CentOS 7 writing help output to stdout, while the version in CentOS 6, and in Ubuntu 16.04, write to stderr instead.
Proposed fix:
diff --git a/scripts/wsrep_sst_xtrabackup-v2.sh b/scripts/wsrep_sst_xtrabackup-v2.shindex a836d5e..6e7dde3 100644--- a/scripts/wsrep_sst_xtrabackup-v2.sh+++ b/scripts/wsrep_sst_xtrabackup-v2.sh@@ -176,7 +176,7 @@ get_transfer()fiwsrep_log_info "Using netcat as streamer"if [[ "$WSREP_SST_OPT_ROLE" == "joiner" ]];then- if nc -h | grep -q ncat;then+ if nc -h 2>&1 | grep -q ncat;thentcmd="nc -l ${TSST_PORT}"elsetcmd="nc -dl ${TSST_PORT}"diff --git a/scripts/wsrep_sst_xtrabackup.sh b/scripts/wsrep_sst_xtrabackup.shindex 2247ede..816c53e 100644--- a/scripts/wsrep_sst_xtrabackup.sh+++ b/scripts/wsrep_sst_xtrabackup.sh@@ -149,7 +149,7 @@ get_transfer()fiwsrep_log_info "Using netcat as streamer"if [[ "$WSREP_SST_OPT_ROLE" == "joiner" ]];then- if nc -h | grep -q ncat;then+ if nc -h 2>&1 | grep -q ncat;thentcmd="nc -l ${TSST_PORT}"elsetcmd="nc -dl ${TSST_PORT}"