Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-10432

Remove bash/lsof dependencies from scripts

    XMLWordPrintable

    Details

      Description

      The wsrep_ scripts contain a number of unneccessary bashisms and needlessly require non-base packages on FreeBSD (lsof, bash).

      I've created a pull-request for this that removes some of the bashisms, uses the POSIX compat mode of bash or another POSIX compatible shell that is found in "/bin/sh" on any system.

      • Non-POSIX "${var}" == "value" -> POSIX "${var}" = "value"
      • Don't use arrays
      • split using ## and %%
      • Use alternative quotes for the FILTERS list

      The `wsrep_sst_rsync.sh` script uses `lsof` to find an rsync instance that listens on the configured port. On platforms with BSD netstat that can be accomplished with netstat from the base system. Currently this checks for $OS = FreeBSD but this should work on other BSD's as well.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              nirbhay_c Nirbhay Choubey (Inactive)
              Reporter:
              spil Bernard Spil
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: