Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-10230

--wsrep_on option no longer passed through by mysqld_safe

Details

    Description

      MDEV-7067 added a --wsrep_on option to mysqld_safe which shadows the mysqld option by the same name. Unlike the --wsrep-provider option --wsrep_on is not passed through to mysld though.

      Attachments

        Issue Links

          links to

          Web Link Commit

          Activity

            Ascending order - Click to sort in descending order
            hholzgra Hartmut Holzgraefe created issue -
            hholzgra Hartmut Holzgraefe added a comment - - edited

            Suggested fix:

            use append_arg_to_args in --wsrep_on option processing to pass through to mysqld

            diff --git a/scripts/mysqld_safe.sh b/scripts/mysqld_safe.sh
            		 
            index c96fc45..ccef5c3 100644
            		 
            --- a/scripts/mysqld_safe.sh
            		 
            +++ b/scripts/mysqld_safe.sh
            		 
            @@ -328,14 +328,21 @@ parse_arguments() {
            		 
                   --timezone=*) TZ="$val"; export TZ; ;;
            		 
                   --flush[-_]caches) flush_caches=1 ;;
            		 
                   --numa[-_]interleave) numa_interleave=1 ;;
            		 
            -      --wsrep[-_]on) wsrep_on=1 ;;
            		 
            -      --skip[-_]wsrep[-_]on) wsrep_on=0 ;;
            		 
            +      --wsrep[-_]on)
            		 
            +        wsrep_on=1
            		 
            +        append_arg_to_args "$arg"
            		 
            +        ;;
            		 
            +      --skip[-_]wsrep[-_]on)
            		 
            +        wsrep_on=0
            		 
            +        append_arg_to_args "$arg"
            		 
            +        ;;
            		 
                   --wsrep[-_]on=*)
            		 
                     if echo $val | grep -iq '\(ON\|1\)'; then
            		 
                       wsrep_on=1
            		 
                     else
            		 
                       wsrep_on=0
            		 
                     fi
            		 
            +        append_arg_to_args "$arg"
            		 
                     ;;
            		 
                   --wsrep[-_]urls=*) wsrep_urls="$val"; ;;
            		 
                   --wsrep[-_]provider=*)

            hholzgra Hartmut Holzgraefe added a comment - - edited Suggested fix: use append_arg_to_args in --wsrep_on option processing to pass through to mysqld diff --git a/scripts/mysqld_safe.sh b/scripts/mysqld_safe.sh index c96fc45..ccef5c3 100644 --- a/scripts/mysqld_safe.sh +++ b/scripts/mysqld_safe.sh @@ -328,14 +328,21 @@ parse_arguments() { --timezone=*) TZ="$val"; export TZ; ;; --flush[-_]caches) flush_caches=1 ;; --numa[-_]interleave) numa_interleave=1 ;; - --wsrep[-_]on) wsrep_on=1 ;; - --skip[-_]wsrep[-_]on) wsrep_on=0 ;; + --wsrep[-_]on) + wsrep_on=1 + append_arg_to_args "$arg" + ;; + --skip[-_]wsrep[-_]on) + wsrep_on=0 + append_arg_to_args "$arg" + ;; --wsrep[-_]on=*) if echo $val | grep -iq '\(ON\|1\)'; then wsrep_on=1 else wsrep_on=0 fi + append_arg_to_args "$arg" ;; --wsrep[-_]urls=*) wsrep_urls="$val"; ;; --wsrep[-_]provider=*)
            hholzgra Hartmut Holzgraefe made changes -
            Field Original Value New Value
            Description MDEV-7067 added a +--wsrep_on+ option to +mysqld_safe+ which shadows the +mysqld+ option by the same name. Unlike the +--wsrep-provider+ option +--wsrep_on+ is not passed through to +mysld+ though.

            		MDEV-7067 added a {{--wsrep_on}} option to {{mysqld_safe}} which shadows the {{mysqld}} option by the same name. Unlike the {{--wsrep-provider}} option {{--wsrep_on}} is not passed through to {{mysld}} though.

            hholzgra Hartmut Holzgraefe made changes -
            Description MDEV-7067 added a {{--wsrep_on}} option to {{mysqld_safe}} which shadows the {{mysqld}} option by the same name. Unlike the {{--wsrep-provider}} option {{--wsrep_on}} is not passed through to {{mysld}} though.

            		MDEV-7067 added a {{\-\-wsrep_on}} option to {{mysqld_safe}} which shadows the {{mysqld}} option by the same name. Unlike the {{\-\-wsrep-provider}} option {{\-\-wsrep_on}} is not passed through to {{mysld}} though.

            elenst Elena Stepanova made changes -
            Component/s wsrep [ 11500 ]
            Fix Version/s 10.1 [ 16100 ]
            Assignee Nirbhay Choubey [ nirbhay_c ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Fix Version/s 10.1.15 [ 22018 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 76003 ] MariaDB v4 [ 150519 ]

            People

              nirbhay_c Nirbhay Choubey (Inactive)
              hholzgra Hartmut Holzgraefe
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.