Uploaded image for project: 'MariaDB Foundation Development'
  1. MariaDB Foundation Development
  2. MDBF-507 Refactor BB factory code
  3. MDBF-960

Document environment variables in master-libvirt

Details

    • Technical task
    • Status: Stalled (View Workflow)
    • Major
    • Resolution: Unresolved
    • N/A
    • N/A
    • Buildbot
    • None
    • Sprint 3 (10.02.2025), Sprint 4 (25.02.2025), Sprint 5 (10.03.2025)

    Description

      There is a lot of code duplication and inconsistency in master-libvirt.

      1. environment variables are passed to each builder separately, but they are all mostly the same. Unify them
      2. the $arch variable is "abused" and used as a way to define a suffix to the mirror and archive URLs. Move that logic out of master.cfg and put it in bash_lib.sh

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          cvicentiu Vicențiu Ciorbaru added a comment - - edited

          Hi Faustin!

          Can you please review the bash_lib.sh changes here:

          https://github.com/MariaDB/buildbot/pull/706

          This commit is the relevant one for bash_lib.sh changes:
          MDBF-960: Decouple master-libvirt arch variable from install/upgrade sripts

          cvicentiu Vicențiu Ciorbaru added a comment - - edited Hi Faustin! Can you please review the bash_lib.sh changes here: https://github.com/MariaDB/buildbot/pull/706 This commit is the relevant one for bash_lib.sh changes: MDBF-960 : Decouple master-libvirt arch variable from install/upgrade sripts
          rvarzaru Varzaru Razvan-Liviu added a comment -

          Please see PR comments.
          Thanks!

          rvarzaru Varzaru Razvan-Liviu added a comment - Please see PR comments. Thanks!

          People

            cvicentiu Vicențiu Ciorbaru
            cvicentiu Vicențiu Ciorbaru
            Varzaru Razvan-Liviu Varzaru Razvan-Liviu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - 0.75d Original Estimate - 0.75d
                0.75d
                Remaining:
                Remaining Estimate - 0d
                0d
                Logged:
                Time Spent - 7h
                7h