Uploaded image for project: 'MariaDB Foundation Development'
  1. MariaDB Foundation Development
  2. MDBF-778

Allow building buildbot workers without a galera included

Details

    • New Feature
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • N/A
    • Buildbot
    • None

    Description

      The Buildbot workers are used to generate galera packages and also by the server to perform MTR tests on galera.

      For new platforms we have no galera build, which creates a problem building the worker.

      Our github CI workflow needs a nogalera input so that there can be a build platform for the galera builder so it can create packages.

      In the mean time the build worker won't have env WSREP_PROVIDER so it won't be automaticlly causing MTR failures for an invalid WSREP_PROVIDER.

      After the galera package has been build, the boolean can be replaced for the next deployment.

      Attachments

        Activity

          However, if it's a platform for which we are going to release packages which require galera for installation, and there is currently no galera to install, at least some tests for this platform must fail very visibly, otherwise we are in danger to end up with an inconsistent release. We've been there before.

          elenst Elena Stepanova added a comment - However, if it's a platform for which we are going to release packages which require galera for installation , and there is currently no galera to install, at least some tests for this platform must fail very visibly, otherwise we are in danger to end up with an inconsistent release. We've been there before.

          elenst I can say for sure that Install tests are failing when there's no Galera built. See for example Fedora 41: https://buildbot.mariadb.org/#/builders/822/builds/1/steps/2/logs/stdio

          danblack you've added no_galera flag a while a go. Please close this item if there are no remaining items.

          rvarzaru Varzaru Razvan-Liviu added a comment - elenst I can say for sure that Install tests are failing when there's no Galera built. See for example Fedora 41: https://buildbot.mariadb.org/#/builders/822/builds/1/steps/2/logs/stdio danblack you've added no_galera flag a while a go. Please close this item if there are no remaining items.

          Yes, that's correct, the package installation is supposed to fail if there is no galera, as the server requires it.
          I don't know what the "no_galera" flag does, but please, don't add anything which imitates a success for package installation if we don't have a consistent set of packages to release – that is, a set of packages which users will be able to install.

          elenst Elena Stepanova added a comment - Yes, that's correct, the package installation is supposed to fail if there is no galera, as the server requires it. I don't know what the "no_galera" flag does, but please, don't add anything which imitates a success for package installation if we don't have a consistent set of packages to release – that is, a set of packages which users will be able to install.
          danblack Daniel Black added a comment -

          correct, nogalera doesn't affect install/upgrade tests.

          It affects mtr tests. Its a solving a little bootstrap problem because the galera CI images and the server CI build images are the same. For server CI images having the WSREP_PROVIDER on the image allows it to do MTR tests on next release galera tested in CI,

          Its only intended as flag to temporary exist until the galera is built. (hence with Julius' permission pushing a few things into galera yesterday straight after the buildbot rollout. We've got a solution deployed that won't need this next time).

          After deployment, like https://github.com/MariaDB/buildbot/pull/622, the nogalera flags are removed where galera packages are built https://buildbot.mariadb.org/#/grid?branch=mariadb-4.x.

          danblack Daniel Black added a comment - correct, nogalera doesn't affect install/upgrade tests. It affects mtr tests. Its a solving a little bootstrap problem because the galera CI images and the server CI build images are the same. For server CI images having the WSREP_PROVIDER on the image allows it to do MTR tests on next release galera tested in CI, Its only intended as flag to temporary exist until the galera is built. (hence with Julius' permission pushing a few things into galera yesterday straight after the buildbot rollout. We've got a solution deployed that won't need this next time). After deployment, like https://github.com/MariaDB/buildbot/pull/622 , the nogalera flags are removed where galera packages are built https://buildbot.mariadb.org/#/grid?branch=mariadb-4.x .

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: