Details
-
Bug
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Won't Fix
-
None
-
None
Description
Buildbot crashes when someone creates a pull request with a UTF8MB4 character because the table that stores the data was created using only 3-byte UTF8 support. An example is this PR:
https://github.com/MariaDB/server/pull/3309
It causes the following error:
sqlalchemy.exc.OperationalError: (MySQLdb._exceptions.OperationalError) (1366, "Incorrect string value: '\\xF0\\x9F\\x93\\x88.\\x0D...' for column `buildbot`.`changes`.`comments` at row 1")
|
[SQL: INSERT INTO changes (author, committer, comments, branch, revision, revlink, when_timestamp, category, repository, codebase, project, sourcestampid, parent_changeids) VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s)]
|
[parameters: ('ParadoxV5', None, 'GitHub Pull Request #3309 (3 commits)\nMDEV-21978 make my_vsnprintf to use gcc-compatible format extensions\n* *The Jira issue number for this PR is: ... (5206 characters truncated) ... my PR conforms to this where appropriate.\r\n* [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.', 'refs/pull/3309/merge', '50a1ab3b631223e69b59e5074447e8199bb08ccb', 'https://github.com/MariaDB/server/pull/3309', 1717554057, 'pull', 'https://github.com/MariaDB/server', '', 'MariaDB/server', 333427, 334127)]
|
(Background on this error at: http://sqlalche.me/e/13/e3q8)
|
The table or column will need modifying to support utf8mb4 to fix this.
In addition the tests in that PR will need to be re-run.
Stretch goal, or for another MDBF: a button in BuildBot or word that authorised people can say in a GitHub PR comment that will trigger a total re-run of buildbot on a PR commit. Other projects have this, we do not see to have such a trigger.
Attachments
Issue Links
- is caused by
-
MDBF-862 Buildbot set all columns to use UTFMB4 on the database
-
- Confirmed
-
Buildbot appears to be hard-coded this way.