Uploaded image for project: 'MariaDB Foundation Development'
  1. MariaDB Foundation Development
  2. MDBF-668

10.5 fails to compile on fc39

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • N/A
    • N/A
    • Buildbot
    • None

    Description

      and it's not supposed to.

      Don't build 10.5 on Fedora 39

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDBF-632 Fedora 39 RPMs not available/builds failing

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDBF-671 10.5 fails to install on fc38

          • Major - Major loss of function.
          • Closed
          is part of

          Task - A task that needs to be done. MDEV-33073 always green buildbot

          • Major - Major loss of function.
          • Stalled

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black added a comment -

            so aarch64 fc39 ok - https://buildbot.mariadb.org/#/builders/593/builds/3402

            amd64-fedora-39-rpm-autobake https://buildbot.mariadb.org/#/builders/596/builds/3183/steps/9/logs/stdio

            		 
            In file included from /home/buildbot/amd64-fedora-39-rpm-autobake/build/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/storage/columnstore/columnstore/storage-manager/src/CloudStorage.cpp:21:
            		 
            /home/buildbot/amd64-fedora-39-rpm-autobake/build/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/storage/columnstore/columnstore/storage-manager/src/S3Storage.h:89:14: error: ‘deque’ in namespace ‘std’ does not name a template type
            		 
               89 |         std::deque<Connection> freeConns;   // using this as a stack to keep lru objects together
            		 
                  |              ^~~~~
            		 
            /home/buildbot/amd64-fedora-39-rpm-autobake/build/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/storage/columnstore/columnstore/storage-manager/src/S3Storage.h:26:1: note: ‘std::deque’ is defined in header ‘<deque>’; did you forget to ‘#include <deque>’?
            		 
               25 | #include "libmarias3/marias3.h"
            		 
              +++ |+#include <deque>
            		 
               26 | #include "Config.h"
            		 
            make[2]: *** [storage/columnstore/columnstore/storage-manager/CMakeFiles/storagemanager.dir/build.make:314: storage/columnstore/columnstore/storage-manager/CMakeFiles/storagemanager.dir/src/CloudStorage.cpp.o] Error 1
            		 
            make[2]: *** Waiting for unfinished jobs....

            MCOL-5612 - columnstore won't fix.

            So disable columnstore for 10.5, fc39 only. (-DPLUGIN_COLUMNSTORE=NO)

            danblack Daniel Black added a comment - so aarch64 fc39 ok - https://buildbot.mariadb.org/#/builders/593/builds/3402 amd64-fedora-39-rpm-autobake https://buildbot.mariadb.org/#/builders/596/builds/3183/steps/9/logs/stdio In file included from /home/buildbot/amd64-fedora-39-rpm-autobake/build/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/storage/columnstore/columnstore/storage-manager/src/CloudStorage.cpp:21: /home/buildbot/amd64-fedora-39-rpm-autobake/build/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/storage/columnstore/columnstore/storage-manager/src/S3Storage.h:89:14: error: ‘deque’ in namespace ‘std’ does not name a template type 89 | std::deque<Connection> freeConns; // using this as a stack to keep lru objects together | ^~~~~ /home/buildbot/amd64-fedora-39-rpm-autobake/build/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/storage/columnstore/columnstore/storage-manager/src/S3Storage.h:26:1: note: ‘std::deque’ is defined in header ‘<deque>’; did you forget to ‘#include <deque>’? 25 | #include "libmarias3/marias3.h" +++ |+#include <deque> 26 | #include "Config.h" make[2]: *** [storage/columnstore/columnstore/storage-manager/CMakeFiles/storagemanager.dir/build.make:314: storage/columnstore/columnstore/storage-manager/CMakeFiles/storagemanager.dir/src/CloudStorage.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... MCOL-5612 - columnstore won't fix. So disable columnstore for 10.5, fc39 only. (-DPLUGIN_COLUMNSTORE=NO)
            serg Sergei Golubchik added a comment -

            we don't ship or support 10.5 on fc39, no need to build it at all

            serg Sergei Golubchik added a comment - we don't ship or support 10.5 on fc39, no need to build it at all
            vladbogo Vlad Bogolin added a comment -

            https://github.com/MariaDB/buildbot/pull/378

            vladbogo Vlad Bogolin added a comment - https://github.com/MariaDB/buildbot/pull/378
            danblack Daniel Black added a comment -

            serg

            Ok, see from https://mariadb.com/kb/en/mariadb-platform-deprecation-policy/ that even fc36+ has been 10.6 for what we distribute.

            So why do we distribute the same version as downstream on Debian and Ubuntu but not Fedora?

            With 10.11 coming to downstream Fedora 40 is it going be the same +1 version for what we distribute?

            danblack Daniel Black added a comment - serg Ok, see from https://mariadb.com/kb/en/mariadb-platform-deprecation-policy/ that even fc36+ has been 10.6 for what we distribute. So why do we distribute the same version as downstream on Debian and Ubuntu but not Fedora? With 10.11 coming to downstream Fedora 40 is it going be the same +1 version for what we distribute?
            serg Sergei Golubchik added a comment -

            I've simply stated what we do now.

            I don't exactly know why we don't build 10.5 for fc39

            serg Sergei Golubchik added a comment - I've simply stated what we do now. I don't exactly know why we don't build 10.5 for fc39
            danblack Daniel Black added a comment -

            Not distributing is 10.5 is ok I guess (though Fedora is one release behind, but given 10.11 effort I'm happy).

            Like macos and FreeBSD I think we should still build as a service to the downstream maintainer so they have a stable tested base to do so their own packaging.

            Addressing Autobake failure:
            https://github.com/MariaDB/server/pull/3159

            danblack Daniel Black added a comment - Not distributing is 10.5 is ok I guess (though Fedora is one release behind, but given 10.11 effort I'm happy). Like macos and FreeBSD I think we should still build as a service to the downstream maintainer so they have a stable tested base to do so their own packaging. Addressing Autobake failure: https://github.com/MariaDB/server/pull/3159
            serg Sergei Golubchik added a comment -

            disabled ColumnStore

            serg Sergei Golubchik added a comment - disabled ColumnStore

            People

              vladbogo Vlad Bogolin
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: