Uploaded image for project: 'MariaDB Foundation Development'
  1. MariaDB Foundation Development
  2. MDBF-1162

Implementing bb's standard db access pattern for last-N-failed builder

    XMLWordPrintable

Details

    • Task
    • Status: In Review (View Workflow)
    • Major
    • Resolution: Unresolved
    • BB v1.12
    • BB V1.13
    • Buildbot
    • None

    Description

      MTRLogObserver is deprecated starting with Buildbot 3.3.0.
      Where possible, without breaking existing builders, we need to
      move away from using MTR related classes and methods.

      In this case, subclassing MTR was not even needed for getting the test failures.

      This patch is implementing the standard db access pattern of Buildbot.
      See:
      https://buildbot.readthedocs.io/en/latest/developer/database.html#module-buildbot.db.pool

      Although the recommended way is to retrieve data through the data api
      our use case is special enough to make an exception, given that
      the test_ table schemas will become in-house maintained when we migrate
      to newer versions of buildbot.

      Attachments

        Issue Links

          Activity

            People

              rvarzaru Varzaru Razvan-Liviu
              rvarzaru Varzaru Razvan-Liviu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 1d
                  1d