Details
-
Bug
-
Status: Open (View Workflow)
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
Sprint 6 (24.03.2025)
Description
Problem: BuildBot not testing the right revision for Pull Requests
Affected build (one of many) https://buildbot.mariadb.org/#/builders/1/builds/54818
where:
- got_revision (what is actually in the tarball) is: 0202b071ab0bcf6cf8663f48c1ab934a3f1b8f33
- and revision (what metadata buildbot received via webhook) is f041b02ec1e28ca0f743abf3bf07e2349b2fab1e
How to reproduce
$ git clone --no-checkout --depth 1 https://github.com/MariaDB/server . |
|
### Try with pull/#ID#/merge - WHAT BUILDBOT DOES
|
$ git fetch https://github.com/MariaDB/server refs/pull/3826/merge --depth 1 |
...
|
...
|
From https://github.com/MariaDB/server |
* branch refs/pull/3826/merge -> FETCH_HEAD |
|
$ git checkout FETCH_HEAD
|
...
|
...
|
HEAD is now at 0202b071 Merge ca561443a28dfbd1b3fb6315187315a12e9fa221 into 839828e57fdf734b15c81cb9cb76d3760a9161f1
|
|
### ONE DAY OLD COMMIT
|
git log
|
commit 0202b071ab0bcf6cf8663f48c1ab934a3f1b8f33 (grafted, HEAD)
|
Author: Marko Mäkelä <marko.makela@mariadb.com>
|
Date: Mon Mar 17 08:52:31 2025 +0100
|
|
Merge ca561443a28dfbd1b3fb6315187315a12e9fa221 into 839828e57fdf734b15c81cb9cb76d3760a9161f1
|
|
### THIS IS NOT OK, LIMIT 45000 shouldn't be present as per PR.
|
$ cat mysql-test/suite/innodb/r/lock_memory_debug.result | grep "t1 g" |
INSERT INTO t1 SELECT a.* FROM t1 a, t1 b, t1 c, t1 d, t1 e, t1 f, t1 g LIMIT 45000;
|
|
|
### Now let's try with pull/#ID#/head
|
$ git fetch https://github.com/MariaDB/server refs/pull/3826/head --depth 1 |
...
|
...
|
From https://github.com/MariaDB/server |
* branch refs/pull/3826/head -> FETCH_HEAD |
|
|
$ git checkout FETCH_HEAD
|
...
|
...
|
HEAD is now at 1f278e70 squash! a878a8ffde539c9c8c1693290d58d1f2d9ba70a8
|
|
### THIS IS OK
|
$ cat mysql-test/suite/innodb/r/lock_memory_debug.result | grep "t1 g;" |
INSERT INTO t1 SELECT a.* FROM t1 a, t1 b, t1 c, t1 d, t1 e, t1 f, t1 g;
|
|
As seen from the printscreen below 1f278e70 is the right commit to test.
BuildBot will use the /merge branch and its HEAD commit is what is packaged on ci.mariadb.org and tested by all builders.