Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
6.1.1
-
None
-
None
-
2021-15, 2021-17
Description
In ColumnStore 6.1.1, the NO_COMPRESSION option for columnstore_compression_type was replaced with a third occurrence of SNAPPY:
const char* mcs_compression_type_names[] = { |
"SNAPPY", // 0 |
"SNAPPY", // 1 |
"SNAPPY", // 2 |
#ifdef HAVE_LZ4
|
"LZ4", // 3 |
#endif
|
NullS
|
};
|
However, the help text for the system variable still refers to the NO_COMPRESSION option:
// compression type
|
static MYSQL_THDVAR_ENUM( |
compression_type,
|
PLUGIN_VAR_RQCMDARG,
|
"Controls compression algorithm for create tables. Possible values are: " |
"NO_COMPRESSION segment files aren't compressed; " |
"SNAPPY segment files are Snappy compressed (default);" |
"LZ4 segment files are LZ4 compressed;", |
NULL, // check |
NULL, // update |
1, //default |
&mcs_compression_type_names_lib); // values lib |
So these two items are inconsistent:
- If columnstore_compression_type should no longer support NO_COMPRESSION, then it should most likely be removed from the help text.
- If columnstore_compression_type should still support NO_COMPRESSION, then it should most likely be added back to mcs_compression_type_names.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 6.2.1 [ 26035 ] |
| Status | Open [ 1 ] | Confirmed [ 10101 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Todd Stoffel [ toddstoffel ] | Roman [ drrtuy ] |
| Assignee | Roman [ drrtuy ] | David Hall [ david.hall ] |
| Fix Version/s | 6.2.2 [ 27000 ] | |
| Fix Version/s | 6.2.1 [ 26035 ] |
| Fix Version/s | 6.3.1 [ 25801 ] | |
| Fix Version/s | 6.2.2 [ 27000 ] |
| Sprint | 2021-15 [ 587 ] |
| Rank | Ranked higher |
| Sprint | 2021-15 [ 587 ] | 2021-15, 2021-16 [ 587, 598 ] |
| Sprint | 2021-15, 2021-16 [ 587, 598 ] | 2021-15 [ 587 ] |
| Rank | Ranked lower |
| Assignee | David Hall [ david.hall ] | Roman [ drrtuy ] |
| Fix Version/s | 6.2.3 [ 27102 ] | |
| Fix Version/s | 6.3.1 [ 25801 ] | |
| Sprint | 2021-15 [ 587 ] | 2021-15, 2021-17 [ 587, 614 ] |
| Assignee | Roman [ drrtuy ] | David Hall [ david.hall ] |
| Status | Confirmed [ 10101 ] | In Review [ 10002 ] |
| Fix Version/s | 6.2.4 [ 27301 ] | |
| Fix Version/s | 6.2.3 [ 27102 ] |
| Status | In Review [ 10002 ] | In Testing [ 10301 ] |
| Assignee | David Hall [ david.hall ] | Daniel Lee [ dleeyh ] |
4QA plz check that the output for mariadbd --help --verbose(with MCS plugin loaded) doesn't mention NO_COMPRESSION in columnstore_compression_type variable description.
Build verified: 6.2.4-1 (#3774)
Reproduced issue in 6.1.1
--column-compression-zlib-wrap
|
--columnstore-compression-type=name
|
Controls compression algorithm for create tables.
|
Possible values are: NO_COMPRESSION segment files aren't
|
--innodb-compression-algorithm[=name]
|
After fix in 6.2.4
--column-compression-zlib-wrap
|
--columnstore-compression-type=name
|
Controls compression algorithm for create tables.
|
--innodb-compression-algorithm[=name]
|
| Resolution | Fixed [ 1 ] | |
| Status | In Testing [ 10301 ] | Closed [ 6 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Fix Version/s | 6.3.1 [ 25801 ] | |
| Fix Version/s | 6.2.4 [ 27301 ] |
| Rank | Ranked higher |
Plz review.