[MCOL-3830] systemctl cat mariadb.service does not work on all systems - Jira

Todd Stoffel (Inactive) created issue - 2020-02-23 00:51

Todd Stoffel (Inactive) made changes - 2020-02-23 00:53

Field	Original Value	New Value
Description	The new version of post-mysql-install relies on systemctl which will not be available inside of a Docker container. We need to rewrite this script to work with Docker and non-Docker systems.	The new version of post-mysql-install relies on systemctl which will not be available inside of a Docker container. We need to rewrite this script to work with Docker and non-Docker systems. As a temporary work-around I have used the old post-mysql-install script and changed the commands mysql-Columnstore to /usr/share/mysql/mysql.server instead: {code:java} #!/bin/bash # # $Id: post-mysql-install 3661 2013-06-25 22:04:33Z dhill $ # # Post-install steps for calpont-mysql install # check log for error checkForError() { # check for password error grep "ERROR 1045" ${tmpdir}/mysql_install.log > ${tmpdir}/error.check if [ `cat ${tmpdir}/error.check \| wc -c` -ne 0 ]; then echo "MySQL Password file missing or incorrect, check .my.cnf file" rm -f ${tmpdir}/error.check /usr/share/mysql/mysql.server stop sleep 2 exit 2; fi rm -f ${tmpdir}/error.check #--------------------------------------------------------------------------- # See if engine columnstore exist #--------------------------------------------------------------------------- echo "checking for engine columnstore..." mysql \ --user=root \ --execute='show engines;' \ \| grep -i columnstore # # Add compressiontype column to SYSCOLUMN if applicable # if [ $? -ne 0 ]; then echo "columnstore doesn't exist" exit 1 fi echo "columnstore exist" return 0; } rpmmode=install tmpdir="/tmp" for arg in "$@"; do if [ $(expr -- "$arg" : '--rpmmode=') -eq 10 ]; then rpmmode="$(echo $arg \| awk -F= '{print $2}')" elif [ $(expr -- "$arg" : '--tmpdir=') -eq 9 ]; then tmpdir="$(echo $arg \| awk -F= '{print $2}')" else echo "ignoring unknown argument: $arg" 1>&2 fi done # Restart in the same way that mysqld will be started normally. /usr/share/mysql/mysql.server stop >/dev/null 2>&1 sleep 2 /usr/share/mysql/mysql.server start --skip-grant-tables sleep 5 # Install various Calpont stuff... install_mcs_mysql.sh --tmpdir=$tmpdir checkForError if [ $? -ne 0 ]; then echo "ERROR: Invalid password in .my.cnf, or Columnstore plugin install missing" /usr/share/mysql/mysql.server stop sleep 2 exit 2; fi /usr/share/mysql/mysql.server stop exit 0 {code}

Todd Stoffel (Inactive) made changes - 2020-02-23 01:07

Rank

Ranked higher

Todd Stoffel (Inactive) made changes - 2020-02-23 01:07

Rank

Ranked higher

Andrew Hutchings (Inactive) made changes - 2020-02-24 07:15

Status

Open [ 1 ]

Needs Feedback [ 10501 ]

Andrew Hutchings (Inactive) made changes - 2020-02-24 17:37

Status

Needs Feedback [ 10501 ]

Open [ 1 ]

David Hall (Inactive) made changes - 2020-02-28 17:39

Fix Version/s

1.4.3 [ 24038 ]

David Hall (Inactive) made changes - 2020-03-02 19:04

Assignee

Jose Rojas [ jrojas ]

David Hall (Inactive) made changes - 2020-03-02 19:05

Fix Version/s

1.5 [ 22800 ]

David Hall (Inactive) made changes - 2020-03-02 19:05

Sprint

2020-4 [ 392 ]

David Hall (Inactive) made changes - 2020-03-02 19:05

Story Points

1

Jose Rojas (Inactive) made changes - 2020-03-03 16:16

Status

Open [ 1 ]

In Progress [ 3 ]

Jose Rojas (Inactive) made changes - 2020-03-03 20:22

Assignee	Jose Rojas [ jrojas ]	Ben Thompson [ ben.thompson ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Jose Rojas (Inactive) made changes - 2020-03-03 20:58

Assignee

Ben Thompson [ ben.thompson ]

Jose Rojas [ jrojas ]

Todd Stoffel (Inactive) made changes - 2020-03-04 04:39

Summary

post-mysql-install will not work with Docker

systemctl cat mariadb.service does not work on all systems

Todd Stoffel (Inactive) made changes - 2020-03-04 04:39

Description

The new version of post-mysql-install relies on systemctl which will not be available inside of a Docker container. We need to rewrite this script to work with Docker and non-Docker systems.

As a temporary work-around I have used the old post-mysql-install script and changed the commands mysql-Columnstore to /usr/share/mysql/mysql.server instead:

{code:java}
#!/bin/bash
#
# $Id: post-mysql-install 3661 2013-06-25 22:04:33Z dhill $
#
# Post-install steps for calpont-mysql install

# check log for error
checkForError() {
# check for password error
grep "ERROR 1045" ${tmpdir}/mysql_install.log > ${tmpdir}/error.check
if [ `cat ${tmpdir}/error.check | wc -c` -ne 0 ]; then
echo "MySQL Password file missing or incorrect, check .my.cnf file"
rm -f ${tmpdir}/error.check
/usr/share/mysql/mysql.server stop
sleep 2
exit 2;
fi

rm -f ${tmpdir}/error.check

        #---------------------------------------------------------------------------
        # See if engine columnstore exist
        #---------------------------------------------------------------------------
        echo "checking for engine columnstore..."
        mysql \
                --user=root \
                --execute='show engines;' \
                | grep -i columnstore

        #
        # Add compressiontype column to SYSCOLUMN if applicable
        #
        if [ $? -ne 0 ]; then
                echo "columnstore doesn't exist"
                exit 1
        fi

        echo "columnstore exist"

return 0;
}

rpmmode=install
tmpdir="/tmp"

for arg in "$@"; do
if [ $(expr -- "$arg" : '--rpmmode=') -eq 10 ]; then
rpmmode="$(echo $arg | awk -F= '{print $2}')"
elif [ $(expr -- "$arg" : '--tmpdir=') -eq 9 ]; then
tmpdir="$(echo $arg | awk -F= '{print $2}')"
else
echo "ignoring unknown argument: $arg" 1>&2
fi
done

# Restart in the same way that mysqld will be started normally.
/usr/share/mysql/mysql.server stop >/dev/null 2>&1
sleep 2
/usr/share/mysql/mysql.server start --skip-grant-tables

sleep 5

# Install various Calpont stuff...
install_mcs_mysql.sh --tmpdir=$tmpdir
checkForError
if [ $? -ne 0 ]; then
    echo "ERROR: Invalid password in .my.cnf, or Columnstore plugin install missing"
    /usr/share/mysql/mysql.server stop
    sleep 2
    exit 2;
fi

/usr/share/mysql/mysql.server stop

exit 0
{code}

The new version of post-mysql-install relies on systemctl, but systemd will not be available inside of a Docker container. We need to rewrite this script to work with system V as well as containerized environments.

As a temporary work-around I have used the old post-mysql-install script and changed the commands mysql-Columnstore to /usr/share/mysql/mysql.server instead:

{code:java}
#!/bin/bash
#
# $Id: post-mysql-install 3661 2013-06-25 22:04:33Z dhill $
#
# Post-install steps for calpont-mysql install

# check log for error
checkForError() {
# check for password error
grep "ERROR 1045" ${tmpdir}/mysql_install.log > ${tmpdir}/error.check
if [ `cat ${tmpdir}/error.check | wc -c` -ne 0 ]; then
echo "MySQL Password file missing or incorrect, check .my.cnf file"
rm -f ${tmpdir}/error.check
/usr/share/mysql/mysql.server stop
sleep 2
exit 2;
fi

rm -f ${tmpdir}/error.check

        #---------------------------------------------------------------------------
        # See if engine columnstore exist
        #---------------------------------------------------------------------------
        echo "checking for engine columnstore..."
        mysql \
                --user=root \
                --execute='show engines;' \
                | grep -i columnstore

        #
        # Add compressiontype column to SYSCOLUMN if applicable
        #
        if [ $? -ne 0 ]; then
                echo "columnstore doesn't exist"
                exit 1
        fi

        echo "columnstore exist"

return 0;
}

rpmmode=install
tmpdir="/tmp"

for arg in "$@"; do
if [ $(expr -- "$arg" : '--rpmmode=') -eq 10 ]; then
rpmmode="$(echo $arg | awk -F= '{print $2}')"
elif [ $(expr -- "$arg" : '--tmpdir=') -eq 9 ]; then
tmpdir="$(echo $arg | awk -F= '{print $2}')"
else
echo "ignoring unknown argument: $arg" 1>&2
fi
done

# Restart in the same way that mysqld will be started normally.
/usr/share/mysql/mysql.server stop >/dev/null 2>&1
sleep 2
/usr/share/mysql/mysql.server start --skip-grant-tables

sleep 5

# Install various Calpont stuff...
install_mcs_mysql.sh --tmpdir=$tmpdir
checkForError
if [ $? -ne 0 ]; then
    echo "ERROR: Invalid password in .my.cnf, or Columnstore plugin install missing"
    /usr/share/mysql/mysql.server stop
    sleep 2
    exit 2;
fi

/usr/share/mysql/mysql.server stop

exit 0
{code}

Todd Stoffel (Inactive) made changes - 2020-03-04 04:43

Description

The new version of post-mysql-install relies on systemctl, but systemd will not be available inside of a Docker container. We need to rewrite this script to work with system V as well as containerized environments.

As a temporary work-around I have used the old post-mysql-install script and changed the commands mysql-Columnstore to /usr/share/mysql/mysql.server instead:

{code:java}
#!/bin/bash
#
# $Id: post-mysql-install 3661 2013-06-25 22:04:33Z dhill $
#
# Post-install steps for calpont-mysql install

# check log for error
checkForError() {
# check for password error
grep "ERROR 1045" ${tmpdir}/mysql_install.log > ${tmpdir}/error.check
if [ `cat ${tmpdir}/error.check | wc -c` -ne 0 ]; then
echo "MySQL Password file missing or incorrect, check .my.cnf file"
rm -f ${tmpdir}/error.check
/usr/share/mysql/mysql.server stop
sleep 2
exit 2;
fi

rm -f ${tmpdir}/error.check

        #---------------------------------------------------------------------------
        # See if engine columnstore exist
        #---------------------------------------------------------------------------
        echo "checking for engine columnstore..."
        mysql \
                --user=root \
                --execute='show engines;' \
                | grep -i columnstore

        #
        # Add compressiontype column to SYSCOLUMN if applicable
        #
        if [ $? -ne 0 ]; then
                echo "columnstore doesn't exist"
                exit 1
        fi

        echo "columnstore exist"

return 0;
}

rpmmode=install
tmpdir="/tmp"

for arg in "$@"; do
if [ $(expr -- "$arg" : '--rpmmode=') -eq 10 ]; then
rpmmode="$(echo $arg | awk -F= '{print $2}')"
elif [ $(expr -- "$arg" : '--tmpdir=') -eq 9 ]; then
tmpdir="$(echo $arg | awk -F= '{print $2}')"
else
echo "ignoring unknown argument: $arg" 1>&2
fi
done

# Restart in the same way that mysqld will be started normally.
/usr/share/mysql/mysql.server stop >/dev/null 2>&1
sleep 2
/usr/share/mysql/mysql.server start --skip-grant-tables

sleep 5

# Install various Calpont stuff...
install_mcs_mysql.sh --tmpdir=$tmpdir
checkForError
if [ $? -ne 0 ]; then
    echo "ERROR: Invalid password in .my.cnf, or Columnstore plugin install missing"
    /usr/share/mysql/mysql.server stop
    sleep 2
    exit 2;
fi

/usr/share/mysql/mysql.server stop

exit 0
{code}

The new version of post-mysql-install, etc rely on systemctl, but systemd will not be running inside of a Docker container for instance.

If the systemctl binary is present and systemd is not running, this will give us a false positive. I suggest we expand the conditional check to verify if systemd is actually running.

Todd Stoffel (Inactive) made changes - 2020-03-04 04:44

Description

The new version of post-mysql-install, etc rely on systemctl, but systemd will not be running inside of a Docker container for instance.

If the systemctl binary is present and systemd is not running, this will give us a false positive. I suggest we expand the conditional check to verify if systemd is actually running.

The new version of post-mysql-install, etc rely on systemctl, but systemd will not be running inside of a Docker container for instance.

If the systemctl binary and the mariadb.service script are present BUT systemd is not running, this will still give us a false positive. I suggest we expand the conditional check to verify if systemd is actually running.

Jose Rojas (Inactive) made changes - 2020-03-04 16:58

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Jose Rojas (Inactive) made changes - 2020-03-04 16:58

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Jose Rojas (Inactive) made changes - 2020-03-10 21:20

Assignee	Jose Rojas [ jrojas ]	Ben Thompson [ ben.thompson ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Todd Stoffel (Inactive) made changes - 2020-03-11 03:19

Rank

Ranked higher

Todd Stoffel (Inactive) made changes - 2020-03-11 04:30

Rank

Ranked higher

Todd Stoffel (Inactive) made changes - 2020-03-13 07:01

Team

ColumnStore Team

David Hall (Inactive) made changes - 2020-03-16 18:29

Sprint

2020-4 [ 392 ]

2020-4, 2020-5 [ 392, 396 ]

David Hall (Inactive) made changes - 2020-03-16 18:32

Sprint

2020-4, 2020-5 [ 392, 396 ]

2020-4 [ 392 ]

David Hall (Inactive) made changes - 2020-03-16 18:32

Sprint

2020-4 [ 392 ]

2020-4, 2020-5 [ 392, 396 ]

David Hall (Inactive) made changes - 2020-03-30 18:46

Sprint

2020-4, 2020-5 [ 392, 396 ]

2020-4, 2020-5, 2020-6 [ 392, 396, 404 ]

Ben Thompson (Inactive) made changes - 2020-04-06 20:53

Status

In Review [ 10002 ]

In Testing [ 10301 ]

Ben Thompson (Inactive) made changes - 2020-04-06 20:53

Assignee

Ben Thompson [ ben.thompson ]

Daniel Lee [ dleeyh ]

Jose Rojas (Inactive) added a comment - 2020-04-06 21:05

Tested shutdown, postConfigure, start, restart, stop on both my develop branch and in Todd's docker container https://github.com/mariadb-corporation/mariadb-enterprise-columnstore-docker to make sure it's working on systems with and without systemd

Jose Rojas (Inactive) added a comment - 2020-04-06 21:05 Tested shutdown, postConfigure, start, restart, stop on both my develop branch and in Todd's docker container https://github.com/mariadb-corporation/mariadb-enterprise-columnstore-docker to make sure it's working on systems with and without systemd

David Hall (Inactive) made changes - 2020-04-13 18:54

Sprint

2020-4, 2020-5, 2020-6 [ 392, 396, 404 ]

2020-4, 2020-5, 2020-6, 2020-7 [ 392, 396, 404, 410 ]

David Hall (Inactive) made changes - 2020-05-05 16:34

Fix Version/s		1.4.5 [ 24424 ]
Fix Version/s	1.4.4 [ 24039 ]

Todd Stoffel (Inactive) made changes - 2020-06-08 16:59

Fix Version/s		1.5.0 [ 24513 ]
Fix Version/s	1.5 [ 22800 ]

Daniel Lee (Inactive) added a comment - 2020-06-10 15:20

Build verified: 1.5.0-1 (drone 20200610, build 65, commit eeb3c842)

Verified lentos 9 and 10, ubuntu 18 and 20

Daniel Lee (Inactive) added a comment - 2020-06-10 15:20 Build verified: 1.5.0-1 (drone 20200610, build 65, commit eeb3c842) Verified lentos 9 and 10, ubuntu 18 and 20

Daniel Lee (Inactive) made changes - 2020-06-10 15:23

Fix Version/s

1.4.5 [ 24424 ]

Daniel Lee (Inactive) added a comment - 2020-06-10 15:24

Testing for 1.4.5-1 is being tracked on ~~MCOL-4051~~. Closing this one for 1.5.0-1.

Daniel Lee (Inactive) added a comment - 2020-06-10 15:24 Testing for 1.4.5-1 is being tracked on MCOL-4051 . Closing this one for 1.5.0-1.

Daniel Lee (Inactive) made changes - 2020-06-10 15:24

Resolution		Fixed [ 1 ]
Status	In Testing [ 10301 ]	Closed [ 6 ]

David Hall (Inactive) made changes - 2020-08-24 16:37

Link

This issue split to ~~MCOL-4051~~ [ ~~MCOL-4051~~ ]

Todd Stoffel (Inactive) made changes - 2020-11-12 03:42

Fix Version/s		1.5.1 [ 24514 ]
Fix Version/s	1.5.0 [ 24513 ]

MariaDB ColumnStore

systemctl cat mariadb.service does not work on all systems

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration