Uploaded image for project: 'MariaDB Connector/node.js'
  1. MariaDB Connector/node.js
  2. CONJS-144

TypeScript type ssl wrong definitions

    XMLWordPrintable

    Details

      Description

      TypeScript type definition has an error on SSL description :

        /**
         * object with ssl parameters or a string containing name of ssl profile
         */
        ssl?: string | (tls.SecureContextOptions & { rejectUnauthorized?: boolean });
      

      must be :

        /**
         * object with ssl parameters
         */
        ssl?: boolean | (tls.SecureContextOptions & { rejectUnauthorized?: boolean });
      
      

      String parameters was for specific profile saved in connector like mysql does with "Amazon RDS" but this create more problem that is helping, so not implemented.

      And boolean option is missing : boolean is the basic option to set SSL when server is using well-known root Certificate Authorities, so not having to set anything client side, just enabling SSL.

        Attachments

          Activity

            People

            Assignee:
            diego dupin Diego Dupin
            Reporter:
            diego dupin Diego Dupin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: